Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 1913343002: [Blob] Removed crash on race case blob messages (Closed)

Created:
4 years, 8 months ago by dmurph
Modified:
4 years, 8 months ago
Reviewers:
kinuko, michaeln
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Blob] Removed crash on race case blob messages We have substantial crashes since adding bad_message errors for invalid blob messages. It looks like there is a pre-existing condition where blob references are race casing across processes. While we investigate the issue, we want to remove this crash so it's not making the situation worse (crashing instead of having a broken blob). I'm keeping the uuid.empty() condition as a bad message, because that's definitely an error that shouldn't be happening. BUG=606065 Committed: https://crrev.com/3f8e7a2ad99e72ed370e17d7258f64dc7acc49fe Cr-Commit-Position: refs/heads/master@{#389868}

Patch Set 1 #

Patch Set 2 : whoops, checking url now instead. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -12 lines) Patch
M content/browser/blob_storage/blob_dispatcher_host.cc View 1 2 chunks +23 lines, -12 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
dmurph
Tiny patch! I want to disable the crashing of renderers due to the invalid refcount ...
4 years, 8 months ago (2016-04-22 22:46:11 UTC) #2
michaeln
lgtm
4 years, 8 months ago (2016-04-25 21:56:12 UTC) #4
kinuko
lgtm.
4 years, 8 months ago (2016-04-26 01:29:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913343002/1
4 years, 8 months ago (2016-04-26 18:31:05 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/128025) chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 8 months ago (2016-04-26 18:44:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913343002/20001
4 years, 8 months ago (2016-04-26 19:20:28 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-26 20:13:32 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 20:14:48 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3f8e7a2ad99e72ed370e17d7258f64dc7acc49fe
Cr-Commit-Position: refs/heads/master@{#389868}

Powered by Google App Engine
This is Rietveld 408576698