Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 1913333002: Mojo C++ bindings: make StrongBinding a message loop destruction observer. (Closed)

Created:
4 years, 8 months ago by yzshen1
Modified:
4 years, 8 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: make StrongBinding a message loop destruction observer. This is a preparation for removing message loop destruction observer from mojo::Watcher. BUG=604762 Committed: https://crrev.com/3f9ef16903199e305ae2ffb3fe74fcdd48e2ded0 Cr-Commit-Position: refs/heads/master@{#389803}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -14 lines) Patch
M chrome/utility/image_decoder_impl_unittest.cc View 1 3 chunks +10 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/strong_binding.h View 4 chunks +25 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
yzshen1
Hi, Ken. Please take a look. Thanks!
4 years, 8 months ago (2016-04-22 22:18:40 UTC) #2
yzshen1
+John for the test changes in chrome/utility. Thanks!
4 years, 8 months ago (2016-04-25 18:12:03 UTC) #4
Ken Rockot(use gerrit already)
lgtm
4 years, 8 months ago (2016-04-25 19:06:57 UTC) #5
jam
lgtm
4 years, 8 months ago (2016-04-26 16:24:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913333002/20001
4 years, 8 months ago (2016-04-26 16:30:37 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-26 16:35:33 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3f9ef16903199e305ae2ffb3fe74fcdd48e2ded0 Cr-Commit-Position: refs/heads/master@{#389803}
4 years, 8 months ago (2016-04-26 16:37:13 UTC) #11
yzshen1
4 years, 7 months ago (2016-05-18 23:39:06 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1993063003/ by yzshen@chromium.org.

The reason for reverting is: As discussed in the mailing thread, I am thinking
to do destruction observation at the router level instead.
.

Powered by Google App Engine
This is Rietveld 408576698