Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
191333002:
stop using deprecated SkBitmap::Config -- use SkColorType instead (Closed)
|
Created:
6 years, 9 months ago by reed1 Modified:
6 years, 9 months ago CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
Descriptionstop using deprecated SkBitmap::Config -- use SkColorType instead
BUG=skia:2239
NOTRY=True
TBR=pfeldman@chromium.org
only failing trybot is mac_rel:telemetry_perfm, which has been failing for a while now. This CL is not related to that area, so skipping that try to land it.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255788
Patch Set 1 #
Messages
Total messages: 19 (0 generated)
lgtm
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/191333002/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/191333002/1
this is the last change (hopefully) needed to land the skia change for copyTo
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/191333002/1
The CQ bit was unchecked by reed@chromium.org
The CQ bit was checked by reed@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
Robert, Ravi : I am having trouble landing this with NOTRY. The failing trybot is not related to this CL. Can you assist?
The CQ bit was checked by rmistry@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/191333002/1
On 2014/03/08 17:36:02, reed2 wrote: > Robert, Ravi : I am having trouble landing this with NOTRY. The failing trybot > is not related to this CL. Can you assist? Strange that it did not work initially. I moved the NOTRY=true in the description around, and checked the CQ bit again. It says the tree is not open but lets see what happens after it opens.
Message was sent while issue was closed.
Change committed as 255788
Message was sent while issue was closed.
On 2014/03/08 18:08:15, I haz the power (commit-bot) wrote: > Change committed as 255788 Cool its in. The only explanation I have for what happened initially: 'NOTRY=true' was added after flipping the CQ bit.
Message was sent while issue was closed.
On 2014/03/08 18:13:12, rmistry wrote: > On 2014/03/08 18:08:15, I haz the power (commit-bot) wrote: > > Change committed as 255788 > > Cool its in. > The only explanation I have for what happened initially: 'NOTRY=true' was added > after flipping the CQ bit. thanks |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
