Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1913323002: Show the toolbar buttons if closing all incognito tabs w/ the url focused. (Closed)

Created:
4 years, 8 months ago by Ted C
Modified:
4 years, 8 months ago
Reviewers:
Yusuf
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show the toolbar buttons if closing all incognito tabs w/ the url focused. We never expected this usecase to be possible so the animation logic was not properly resetting the visiblity. BUG=600301 Committed: https://crrev.com/aa4b9d1275e41bc340358a545bbe56831e291ee2 Cr-Commit-Position: refs/heads/master@{#389282}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Ted C
PTAL
4 years, 8 months ago (2016-04-22 21:49:42 UTC) #2
Yusuf
lgtm
4 years, 8 months ago (2016-04-22 21:51:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913323002/1
4 years, 8 months ago (2016-04-22 22:02:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 22:52:05 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 22:53:26 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa4b9d1275e41bc340358a545bbe56831e291ee2
Cr-Commit-Position: refs/heads/master@{#389282}

Powered by Google App Engine
This is Rietveld 408576698