Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1913313002: Turn off background compilation when running with --verify_gc, since the background compilation con… (Closed)

Created:
4 years, 8 months ago by srdjan
Modified:
4 years, 8 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Turn off background compilation when running with --verify_gc, since the background compilation constantly forces mutator thread to reach safepoint and vice versa. This can take too much time. Add a different source-code position for UNREACHABLE in AbstractType::IsInstantiated to analyze very rare crashes BUG= R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/d109b17eadf36896ee2de29cc54ff54fa4d7bd48

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M runtime/vm/object.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/lib/convert/streamed_conversion_json_utf8_decode_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
srdjan
4 years, 8 months ago (2016-04-22 21:08:48 UTC) #2
regis
LGTM
4 years, 8 months ago (2016-04-22 22:30:59 UTC) #3
srdjan
4 years, 8 months ago (2016-04-22 22:38:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d109b17eadf36896ee2de29cc54ff54fa4d7bd48 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698