Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1913293002:
Limit tab sharing to Dev and Canary (Closed)
|
Created:
4 years, 8 months ago by Niklas Enbom Modified:
4 years, 8 months ago CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionLimit tab sharing to Dev and Canary
BUG=606029
Committed: https://crrev.com/3c0cfab073beb1c5837494be0dc384ef43f636a0
Cr-Commit-Position: refs/heads/master@{#389317}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Setting to true when needed #
Total comments: 1
Patch Set 3 : formatting #Messages
Total messages: 19 (9 generated)
Description was changed from ========== Limit tab sharing to Dev and Canary BUG=606029 ========== to ========== Limit tab sharing to Dev and Canary BUG=606029 ==========
niklase@chromium.org changed reviewers: + qiangchen@chromium.org
Qiang can you take a quick look before OWNERs since this is your code.
niklase@chromium.org changed reviewers: + sergeyu@chromium.org
+sergeyu as OWNER
https://codereview.chromium.org/1913293002/diff/1/chrome/browser/extensions/a... File chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc (right): https://codereview.chromium.org/1913293002/diff/1/chrome/browser/extensions/a... chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc:112: show_tabs = false; show_tabs is false by default, so this assignment won't do anything. I think you need the assignment statement here as it was before, or set the flag to true on DEV and CANARY channels. Also need {} here for multi-line if statement.
Doh, sorry for the sloppy work when trying to do this quickly. updated. On 2016/04/22 21:55:26, Sergey Ulanov wrote: > https://codereview.chromium.org/1913293002/diff/1/chrome/browser/extensions/a... > File chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc > (right): > > https://codereview.chromium.org/1913293002/diff/1/chrome/browser/extensions/a... > chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc:112: > show_tabs = false; > show_tabs is false by default, so this assignment won't do anything. I think you > need the assignment statement here as it was before, or set the flag to true on > DEV and CANARY channels. > Also need {} here for multi-line if statement.
lgtm https://codereview.chromium.org/1913293002/diff/20001/chrome/browser/extensio... File chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc (right): https://codereview.chromium.org/1913293002/diff/20001/chrome/browser/extensio... chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc:113: }else{ nit: add spaces around else please (or 'git cl format' can do it for you)
The CQ bit was checked by niklase@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913293002/20001
The CQ bit was unchecked by niklase@chromium.org
The CQ bit was checked by niklase@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org Link to the patchset: https://codereview.chromium.org/1913293002/#ps40001 (title: "formatting")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913293002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913293002/40001
Message was sent while issue was closed.
Description was changed from ========== Limit tab sharing to Dev and Canary BUG=606029 ========== to ========== Limit tab sharing to Dev and Canary BUG=606029 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Limit tab sharing to Dev and Canary BUG=606029 ========== to ========== Limit tab sharing to Dev and Canary BUG=606029 Committed: https://crrev.com/3c0cfab073beb1c5837494be0dc384ef43f636a0 Cr-Commit-Position: refs/heads/master@{#389317} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/3c0cfab073beb1c5837494be0dc384ef43f636a0 Cr-Commit-Position: refs/heads/master@{#389317}
Message was sent while issue was closed.
lgtm |
