media/capture/content/thread_safe_capture_oracle.h - Issue 1913283004: Aura Window Capture: Ensure capture callback is always run.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/capture/content/thread_safe_capture_oracle.h

Issue 1913283004: Aura Window Capture: Ensure capture callback is always run. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix hole in ThreadSafeCaptureOracle as well. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/media/capture/aura_window_capture_machine.cc ('k') | media/capture/content/thread_safe_capture_oracle.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/capture/content/thread_safe_capture_oracle.h

diff --git a/media/capture/content/thread_safe_capture_oracle.h b/media/capture/content/thread_safe_capture_oracle.h

index 1f16e2f824b321c8e2fdc48ac69c18195ea70ce0..58841a67207d2cff3530e10f7be3d83cf1b3ba1f 100644

--- a/media/capture/content/thread_safe_capture_oracle.h

+++ b/media/capture/content/thread_safe_capture_oracle.h

@@ -48,9 +48,10 @@ class MEDIA_EXPORT ThreadSafeCaptureOracle

// resources.

// If this method returns false, the caller should take no further action.

- // Otherwise, |storage| is set to the destination for the video frame capture;

- // and, the caller should initiate capture, and then run |callback| once the

- // video frame has been populated with its content.

+ // Otherwise, |storage| is set to the destination for the video frame capture

+ // and the caller should initiate capture. Then, once the video frame has

+ // been populated with its content, or if capture failed, the |callback|

+ // should be run.

bool ObserveEventAndDecideCapture(VideoCaptureOracle::Event event,

const gfx::Rect& damage_rect,

base::TimeTicks event_time,