Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: content/browser/media/capture/aura_window_capture_machine.h

Issue 1913283004: Aura Window Capture: Ensure capture callback is always run. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/capture/aura_window_capture_machine.h
diff --git a/content/browser/media/capture/aura_window_capture_machine.h b/content/browser/media/capture/aura_window_capture_machine.h
index 84a6ba25a4ff1b4d96a2aa07609ec5e75bdfec18..10a25abf10b0b8373a1fa262d99ca411cbe9fe3a 100644
--- a/content/browser/media/capture/aura_window_capture_machine.h
+++ b/content/browser/media/capture/aura_window_capture_machine.h
@@ -89,7 +89,9 @@ class AuraWindowCaptureMachine
std::unique_ptr<cc::CopyOutputResult> result);
// A helper which does the real work for DidCopyOutput. Returns true if
- // succeeded.
+ // succeeded and |capture_frame_cb| will be run at some future point. Returns
+ // false on error, and |capture_frame_cb| should be run by the caller (with
+ // failure status).
bool ProcessCopyOutputResponse(scoped_refptr<media::VideoFrame> video_frame,
base::TimeTicks start_time,
const CaptureFrameCallback& capture_frame_cb,

Powered by Google App Engine
This is Rietveld 408576698