third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp - Issue 1913283003: [DevTools] Rework idle{Started,Finished} instrumentation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp

Issue 1913283003: [DevTools] Rework idle{Started,Finished} instrumentation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1907663005

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp ('K') | « third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h ('k') | third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp

index c31f62129820d9eeb202312b7a1aad864ad5b452..b813717e919f5c77e6ea323c6d81b799c4c8b988 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp

@@ -290,18 +290,4 @@ bool V8ProfilerAgentImpl::isRecording() const

return m_recordingCPUProfile || !m_startedProfiles.isEmpty();

}

-void V8ProfilerAgentImpl::idleFinished()

- if (!isRecording())

- return;

- m_isolate->GetCpuProfiler()->SetIdle(false);

-void V8ProfilerAgentImpl::idleStarted()

- if (!isRecording())

- return;

- m_isolate->GetCpuProfiler()->SetIdle(true);

} // namespace blink