Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Side by Side Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 1913283003: [DevTools] Rework idle{Started,Finished} instrumentation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@1907663005
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010-2011 Google Inc. All rights reserved. 2 * Copyright (C) 2010-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 636 matching lines...) Expand 10 before | Expand all | Expand 10 after
647 void WebDevToolsAgentImpl::flushPendingProtocolNotifications() 647 void WebDevToolsAgentImpl::flushPendingProtocolNotifications()
648 { 648 {
649 if (m_session) 649 if (m_session)
650 m_session->flushPendingProtocolNotifications(); 650 m_session->flushPendingProtocolNotifications();
651 } 651 }
652 652
653 void WebDevToolsAgentImpl::willProcessTask() 653 void WebDevToolsAgentImpl::willProcessTask()
654 { 654 {
655 if (!attached()) 655 if (!attached())
656 return; 656 return;
657 InspectorInstrumentation::willProcessTask(m_inspectedFrames->root()); 657 ThreadDebugger::idleFinished(V8PerIsolateData::mainThreadIsolate());
658 } 658 }
659 659
660 void WebDevToolsAgentImpl::didProcessTask() 660 void WebDevToolsAgentImpl::didProcessTask()
661 { 661 {
662 if (!attached()) 662 if (!attached())
663 return; 663 return;
664 InspectorInstrumentation::didProcessTask(m_inspectedFrames->root()); 664 ThreadDebugger::idleStarted(V8PerIsolateData::mainThreadIsolate());
665 flushPendingProtocolNotifications(); 665 flushPendingProtocolNotifications();
666 } 666 }
667 667
668 void WebDevToolsAgentImpl::runDebuggerTask(int sessionId, PassOwnPtr<WebDevTools Agent::MessageDescriptor> descriptor) 668 void WebDevToolsAgentImpl::runDebuggerTask(int sessionId, PassOwnPtr<WebDevTools Agent::MessageDescriptor> descriptor)
669 { 669 {
670 WebDevToolsAgent* webagent = descriptor->agent(); 670 WebDevToolsAgent* webagent = descriptor->agent();
671 if (!webagent) 671 if (!webagent)
672 return; 672 return;
673 673
674 WebDevToolsAgentImpl* agentImpl = static_cast<WebDevToolsAgentImpl*>(webagen t); 674 WebDevToolsAgentImpl* agentImpl = static_cast<WebDevToolsAgentImpl*>(webagen t);
(...skipping 13 matching lines...) Expand all
688 if (!protocol::Dispatcher::getCommandName(message, &commandName)) 688 if (!protocol::Dispatcher::getCommandName(message, &commandName))
689 return false; 689 return false;
690 return commandName == "Debugger.pause" 690 return commandName == "Debugger.pause"
691 || commandName == "Debugger.setBreakpoint" 691 || commandName == "Debugger.setBreakpoint"
692 || commandName == "Debugger.setBreakpointByUrl" 692 || commandName == "Debugger.setBreakpointByUrl"
693 || commandName == "Debugger.removeBreakpoint" 693 || commandName == "Debugger.removeBreakpoint"
694 || commandName == "Debugger.setBreakpointsActive"; 694 || commandName == "Debugger.setBreakpointsActive";
695 } 695 }
696 696
697 } // namespace blink 697 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698