Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1913283002: Trim Skia dependencies in Blink (Closed)

Created:
4 years, 8 months ago by tomhudson
Modified:
4 years, 7 months ago
CC:
ajuma+watch-canvas_chromium.org, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-html_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-style_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dcheng, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), haraken, jbroman, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Trim Skia dependencies in Blink Reduce coupling by removing Skia #includes from headers, switching to the *correct* Skia #includes, or changing to forward declarations. R=fmalita@chromium.org,junov@chromium.org BUG=604716 Committed: https://crrev.com/1a794d387568cadc30e8e585dec2f6514ddef821 Cr-Commit-Position: refs/heads/master@{#390423}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -18 lines) Patch
M third_party/WebKit/Source/core/frame/ImageBitmap.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasDrawListener.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasStyle.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/DragImageTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/FrameData.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/FrameData.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsTypes.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/PaintGeneratedImage.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ReplayingCanvas.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/StrokeData.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/StrokeData.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/skia/ImagePixelLocker.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/skia/SkiaUtils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/WebDisplayItemList.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913283002/1
4 years, 8 months ago (2016-04-22 21:05:22 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-23 01:35:40 UTC) #4
tomhudson
junov@: please review modules fmalita@: please review everything else
4 years, 8 months ago (2016-04-25 12:22:39 UTC) #7
Justin Novosad
On 2016/04/25 12:22:39, tomhudson wrote: > junov@: please review modules > fmalita@: please review everything ...
4 years, 8 months ago (2016-04-25 13:36:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913283002/1
4 years, 8 months ago (2016-04-25 13:42:59 UTC) #10
tomhudson
On 2016/04/25 13:36:14, Justin Novosad wrote: > On 2016/04/25 12:22:39, tomhudson wrote: > > junov@: ...
4 years, 8 months ago (2016-04-25 13:43:07 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/172619)
4 years, 8 months ago (2016-04-25 13:54:45 UTC) #13
tomhudson
Chris, please review third_party/WebKit/public/platform/WebDisplayItemList.h
4 years, 8 months ago (2016-04-26 17:52:46 UTC) #15
f(malita)
LGTM too w/ a couple of minor suggestions (but public/platform owner RS still needed). https://codereview.chromium.org/1913283002/diff/1/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h ...
4 years, 7 months ago (2016-04-28 14:06:46 UTC) #16
chrishtr
lgtm
4 years, 7 months ago (2016-04-28 15:15:08 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913283002/20001
4 years, 7 months ago (2016-04-28 16:59:05 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-28 18:19:33 UTC) #22
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:19:38 UTC) #23
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1a794d387568cadc30e8e585dec2f6514ddef821
Cr-Commit-Position: refs/heads/master@{#390423}

Powered by Google App Engine
This is Rietveld 408576698