Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: net/url_request/url_request.cc

Issue 1913273003: Remove stack trace from URLFetcher / URLRequest for debugging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request.cc
diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc
index d6582e3404ea13ab1d708a1502e27cf70973ffb3..77cbf42bcfe431eddb4b0faad093bbede65e8298 100644
--- a/net/url_request/url_request.cc
+++ b/net/url_request/url_request.cc
@@ -10,7 +10,6 @@
#include "base/bind_helpers.h"
#include "base/callback.h"
#include "base/compiler_specific.h"
-#include "base/debug/stack_trace.h"
#include "base/lazy_instance.h"
#include "base/memory/singleton.h"
#include "base/message_loop/message_loop.h"
@@ -1191,14 +1190,6 @@ void URLRequest::OnCallToDelegateComplete() {
net_log_.EndEvent(NetLog::TYPE_URL_REQUEST_DELEGATE);
}
-void URLRequest::set_stack_trace(const base::debug::StackTrace& stack_trace) {
- stack_trace_.reset(new base::debug::StackTrace(stack_trace));
-}
-
-const base::debug::StackTrace* URLRequest::stack_trace() const {
- return stack_trace_.get();
-}
-
void URLRequest::GetConnectionAttempts(ConnectionAttempts* out) const {
if (job_)
job_->GetConnectionAttempts(out);

Powered by Google App Engine
This is Rietveld 408576698