Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: content/renderer/media/video_track_recorder.cc

Issue 1913233002: Fix MediaRecorder bitrate configuration bug (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: correct a comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/video_track_recorder.cc
diff --git a/content/renderer/media/video_track_recorder.cc b/content/renderer/media/video_track_recorder.cc
index 6a2e68f42a56c7bb8b374015fed6b9c4a70ba211..6d2dfcf97dfc4799df0f024ce7c766d4008c1da3 100644
--- a/content/renderer/media/video_track_recorder.cc
+++ b/content/renderer/media/video_track_recorder.cc
@@ -292,9 +292,9 @@ void VpxEncoder::ConfigureEncoding(const gfx::Size& size) {
DCHECK_EQ(240u, codec_config_.g_h);
DCHECK_EQ(256u, codec_config_.rc_target_bitrate);
// Use the selected bitrate or adjust default bit rate to account for the
- // actual size.
+ // actual size. Note: |rc_target_bitrate| units are kbit per second.
if (bits_per_second_ > 0) {
- codec_config_.rc_target_bitrate = bits_per_second_;
+ codec_config_.rc_target_bitrate = bits_per_second_ / 1000;
} else {
codec_config_.rc_target_bitrate = size.GetArea() *
codec_config_.rc_target_bitrate /
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698