Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1594)

Unified Diff: android_webview/tools/webview_licenses.py

Issue 191323002: aw: Mark Quickoffice dir as known license issue (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/tools/webview_licenses.py
diff --git a/android_webview/tools/webview_licenses.py b/android_webview/tools/webview_licenses.py
index db82fa4d6538b450f6f508b4d8445f7bbd74c882..f9ed1961d9f148885e5c1a30fb0a957a54f81872 100755
--- a/android_webview/tools/webview_licenses.py
+++ b/android_webview/tools/webview_licenses.py
@@ -119,7 +119,7 @@ def _CheckLicenseHeaders(excluded_dirs_list, whitelisted_files):
excluded_dirs_list.append('out/Release')
# 'Copyright' appears in license agreements
excluded_dirs_list.append('chrome/app/resources')
- # Quickoffice js files from internal src used on buildbots
+ # Quickoffice js files from internal src used on buildbots. crbug.com/350472.
excluded_dirs_list.append('chrome/browser/resources/chromeos/quickoffice')
# This is a test output directory
excluded_dirs_list.append('chrome/tools/test/reference_build')
@@ -210,6 +210,9 @@ def _FindThirdPartyDirs():
# as they will end up included in Android WebView snapshot.
# Instead, add them into known_issues.py.
prune_paths = [
+ # Temporary until we figure out how not to check out quickoffice on the
+ # Android license check bot. Tracked in crbug.com/350472.
+ os.path.join('chrome', 'browser', 'resources', 'chromeos', 'quickoffice'),
# Placeholder directory, no third-party code.
os.path.join('third_party', 'adobe'),
# Apache 2.0 license. See
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698