Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issue 1913203002: Widen --harmony-for-in flag to throw errors in PreParser (Closed)

Created:
4 years, 8 months ago by adamk
Modified:
4 years, 7 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Widen --harmony-for-in flag to throw errors in PreParser The first version of --harmony-for-in avoided throwing PreParser errors in order to retain use counting. This patch threads use_counts_ through to the PreParser to allow use counting in the PreParser while also throwing errors for this case. Also slightly refactored the Parser code to do a little less code duplication. BUG=v8:4942 LOG=y Committed: https://crrev.com/739947880cd1e9a8cc1ad1d6c26ca5a1442541f3 Cr-Commit-Position: refs/heads/master@{#35780}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -20 lines) Patch
M src/parsing/parser.cc View 5 chunks +10 lines, -14 lines 0 comments Download
M src/parsing/parser-base.h View 3 chunks +3 lines, -0 lines 0 comments Download
M src/parsing/preparser.h View 3 chunks +5 lines, -2 lines 0 comments Download
M src/parsing/preparser.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M test/cctest/test-parsing.cc View 3 chunks +23 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
adamk
4 years, 8 months ago (2016-04-22 18:23:40 UTC) #2
rossberg
lgtm
4 years, 8 months ago (2016-04-25 11:42:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913203002/1
4 years, 8 months ago (2016-04-25 23:43:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-26 00:29:45 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 00:30:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/739947880cd1e9a8cc1ad1d6c26ca5a1442541f3
Cr-Commit-Position: refs/heads/master@{#35780}

Powered by Google App Engine
This is Rietveld 408576698