Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 1913183003: Fix the archive_build step for Win x64. (Closed)

Created:
4 years, 8 months ago by Dirk Pranke
Modified:
4 years, 8 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Fix the archive_build step for Win x64. The recipe code was looking at the build config (Release) instead of the filesystem directory name (Release_x64) and as a result the archive_build step has been failing on the new 'Win x64' builder on the chromium waterfall. TBR=phajdan.jr@chromium.org, kjellander@chromium.org BUG=605860 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300117

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M scripts/slave/recipe_modules/chromium/api.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_Win_x64.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Dirk Pranke
4 years, 8 months ago (2016-04-22 17:03:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913183003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913183003/1
4 years, 8 months ago (2016-04-22 17:03:40 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 17:07:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300117

Powered by Google App Engine
This is Rietveld 408576698