Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1913173003: SkMD5: .update() -> .write() (Closed)

Created:
4 years, 8 months ago by hal.canary
Modified:
4 years, 8 months ago
Reviewers:
tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 : 2016-04-22 (Friday) 16:17:21 EDT #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M bench/ChecksumBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkMD5.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkMD5.cpp View 1 chunk +2 lines, -2 lines 1 comment Download
M tests/CodecTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/MD5Test.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/PictureTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913173003/1
4 years, 8 months ago (2016-04-22 20:13:11 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/8053) Build-Win-MSVC-x86_64-Debug-Trybot on ...
4 years, 8 months ago (2016-04-22 20:15:41 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913173003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913173003/20001
4 years, 8 months ago (2016-04-22 20:17:51 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-22 20:27:42 UTC) #10
hal.canary
ptal
4 years, 8 months ago (2016-04-22 20:32:58 UTC) #13
tomhudson
lgtm https://codereview.chromium.org/1913173003/diff/20001/src/core/SkMD5.cpp File src/core/SkMD5.cpp (right): https://codereview.chromium.org/1913173003/diff/20001/src/core/SkMD5.cpp#newcode86 src/core/SkMD5.cpp:86: (void)this->write(bits, 8); Having to cast void return. :(
4 years, 8 months ago (2016-04-22 20:49:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913173003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913173003/20001
4 years, 8 months ago (2016-04-25 17:14:20 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 17:29:39 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://skia.googlesource.com/skia/+/1e9030472e59befbe8faaf42fd166300534d97d3

Powered by Google App Engine
This is Rietveld 408576698