Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1913173002: PPC: [interpreter] Heal closures when bytecode array is gone. (Closed)

Created:
4 years, 8 months ago by JaideepBajwa
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [interpreter] Heal closures when bytecode array is gone. Port 5c8609de9d597000fdb92dffe954d7ed994488b2 Original commit message: This ensures the InterpreterEntryTrampoline heals code entry fields inside closures when being called without a valid bytecode array. This is preparatory work to allow removal of bytecode when switching some functions to other types of code. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4280 LOG=N Committed: https://crrev.com/6d9c4c86635bd6bf3ec2831f93adf343fa125f91 Cr-Commit-Position: refs/heads/master@{#35739}

Patch Set 1 #

Patch Set 2 : fixed to use JumpToJSEntry #

Patch Set 3 : fixed register name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M src/ppc/builtins-ppc.cc View 1 2 3 chunks +20 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 8 months ago (2016-04-22 16:45:47 UTC) #1
MTBrandyberry
lgtm
4 years, 8 months ago (2016-04-22 17:27:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913173002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913173002/40001
4 years, 8 months ago (2016-04-22 17:31:57 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-22 17:56:13 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:15:56 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6d9c4c86635bd6bf3ec2831f93adf343fa125f91
Cr-Commit-Position: refs/heads/master@{#35739}

Powered by Google App Engine
This is Rietveld 408576698