Support ignores at end of line (#26181).

Support ignores at end of line (#26181).

Implements: https://github.com/dart-lang/sdk/issues/26181

BUG=
R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/6b2060598491e106f941bafe20a53467f26958ea

[pquitslund, 2016-04-22 13:47:15]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-04-22 14:10:23]

lgtm

https://codereview.chromium.org/1913113002/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1913113002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:2427: while
(lineInfo.getLocation(token.offset).lineNumber < line) {
I don't have the code handy, but I think there's a way to ask the lineInfo for
the offset of the given line, then you could write the loop condition to look
for the first token at or after that offset, which would be more efficient (in
part because it would produce far fewer temporary objects).

https://codereview.chromium.org/1913113002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:2465: if (commentLine == previousTokenLine)
{
Don't we want to compare commentLine to the errorLine?

[pquitslund, 2016-04-22 16:18:48]

Fixed up.  Thanks!

https://codereview.chromium.org/1913113002/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1913113002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:2427: while
(lineInfo.getLocation(token.offset).lineNumber < line) {
On 2016/04/22 14:10:23, Brian Wilkerson wrote:
> I don't have the code handy, but I think there's a way to ask the lineInfo for
> the offset of the given line, then you could write the loop condition to look
> for the first token at or after that offset, which would be more efficient (in
> part because it would produce far fewer temporary objects).

Oh nice.  Only one call to `lineInfo`.  Good idea, thanks!

https://codereview.chromium.org/1913113002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:2465: if (commentLine == previousTokenLine)
{
On 2016/04/22 14:10:22, Brian Wilkerson wrote:
> Don't we want to compare commentLine to the errorLine?

Simpler, yes.  Done.

[pquitslund, 2016-04-22 18:06:20]

Description was changed from

==========
Support ignores at end of line (#26181).

Implements: https://github.com/dart-lang/sdk/issues/26181

BUG=
==========

to

==========
Support ignores at end of line (#26181).

Implements: https://github.com/dart-lang/sdk/issues/26181

BUG=
R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6b2060598491e106f941bafe20a53467f26958ea
==========

[pquitslund, 2016-04-22 18:06:21]

Committed patchset #1 (id:1) manually as
6b2060598491e106f941bafe20a53467f26958ea (presubmit successful).