Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1913103002: Revert of 🐎 Remove --shard-timeout from webrtc recipes now that they are in wrapper scripts (Closed)

Created:
4 years, 8 months ago by kjellander_chromium
Modified:
4 years, 8 months ago
Reviewers:
agrieve
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@wrapper-3
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of 🐎 Remove --shard-timeout from webrtc recipes now that they are in wrapper scripts (patchset #1 id:1 of https://codereview.chromium.org/1882293003/ ) Reason for revert: It seems the run_* scripts in WebRTC actually don't include the timeouts yet, I will investigate before relanding this. Original issue's description: > Remove --shard-timeout from webrtc recipes now that they are in wrapper scripts > > BUG=599919 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300083 TBR=agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=599919, 605897 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300114

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+660 lines, -217 lines) Patch
M scripts/slave/recipe_modules/webrtc/steps.py View 3 chunks +20 lines, -7 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5_.json View 13 chunks +50 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__dbg_.json View 13 chunks +39 lines, -13 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__failing_test.json View 13 chunks +50 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus5__forced.json View 13 chunks +50 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus7_2_.json View 13 chunks +50 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android32_tests__l_nexus7_2__dbg_.json View 13 chunks +39 lines, -13 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android64_tests__l_nexus9_.json View 13 chunks +50 lines, -16 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_asan__l_nexus6_.json View 13 chunks +39 lines, -13 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__j_nexus4_.json View 13 chunks +39 lines, -13 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__k_nexus5_.json View 13 chunks +39 lines, -13 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_android32_tests__l_nexus6_.json View 13 chunks +39 lines, -13 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64_rel.json View 13 chunks +39 lines, -13 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_dbg.json View 13 chunks +39 lines, -13 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_n6.json View 13 chunks +39 lines, -13 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json View 13 chunks +39 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kjellander_chromium
Created Revert of 🐎 Remove --shard-timeout from webrtc recipes now that they are in wrapper ...
4 years, 8 months ago (2016-04-22 12:11:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913103002/1
4 years, 8 months ago (2016-04-22 12:11:36 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300114
4 years, 8 months ago (2016-04-22 12:11:46 UTC) #6
kjellander_chromium
4 years, 8 months ago (2016-04-22 13:15:49 UTC) #7
Message was sent while issue was closed.
On 2016/04/22 12:11:46, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
> http://src.chromium.org/viewvc/chrome?view=rev&revision=300114

Ah, now I see why this happened. Our perf tests are wrapped in runtest.py, which
causes an error:
https://build.chromium.org/p/client.webrtc/builders/Android64%20Tests%20%28L%...

I'll work on this on Monday to reland.

Powered by Google App Engine
This is Rietveld 408576698