Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp

Issue 1913093003: [DevTools] Remove reference to DebuggerAgent from ConsoleAgent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp
index 7b0013a33c171a464fc48621fd42e637c6f34e02..0d7368b95ad1df2754ea74b67a0c2c947346165e 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp
@@ -31,8 +31,6 @@
#include "core/inspector/ConsoleMessageStorage.h"
#include "core/inspector/IdentifiersFactory.h"
#include "core/inspector/ScriptArguments.h"
-#include "platform/v8_inspector/public/V8Debugger.h"
-#include "platform/v8_inspector/public/V8DebuggerAgent.h"
#include "platform/v8_inspector/public/V8RuntimeAgent.h"
#include "wtf/text/WTFString.h"
@@ -42,10 +40,9 @@ namespace ConsoleAgentState {
static const char consoleMessagesEnabled[] = "consoleMessagesEnabled";
}
-InspectorConsoleAgent::InspectorConsoleAgent(V8RuntimeAgent* runtimeAgent, V8DebuggerAgent* debuggerAgent)
+InspectorConsoleAgent::InspectorConsoleAgent(V8RuntimeAgent* runtimeAgent)
: InspectorBaseAgent<InspectorConsoleAgent, protocol::Frontend::Console>("Console")
, m_runtimeAgent(runtimeAgent)
- , m_debuggerAgent(debuggerAgent)
, m_enabled(false)
{
}
@@ -99,11 +96,6 @@ void InspectorConsoleAgent::restore()
void InspectorConsoleAgent::addMessageToConsole(ConsoleMessage* consoleMessage)
{
sendConsoleMessageToFrontend(consoleMessage, true);
- if (consoleMessage->type() != AssertMessageType)
- return;
- if (!m_debuggerAgent)
- return;
- m_debuggerAgent->breakProgramOnException(protocol::Debugger::Paused::ReasonEnum::Assert, nullptr);
}
void InspectorConsoleAgent::clearAllMessages()

Powered by Google App Engine
This is Rietveld 408576698