Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1913023002: Revert of [remoting android] Initialize It2Me host and implement Connect() (Closed)

Created:
4 years, 8 months ago by jbudorick
Modified:
4 years, 8 months ago
Reviewers:
Sergey Ulanov, Lambros
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [remoting android] Initialize It2Me host and implement Connect() (patchset #4 id:60001 of https://codereview.chromium.org/1888653002/ ) Reason for revert: breaks downstream compilation Original issue's description: > [remoting android] Initialize It2Me host and implement Connect() > > This adds a "Share" button. Clicking it brings up an account-chooser > dialog for selecting the account to use for XMPP. > Then it connects to the Directory server, and gets back an It2Me access > code. > > BUG=602355 TBR=sergeyu@chromium.org,lambroslambrou@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=602355 Committed: https://crrev.com/58294a735594816eb0110d0248c8282d9c1a4ae8 Cr-Commit-Position: refs/heads/master@{#389001}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -228 lines) Patch
M remoting/android/BUILD.gn View 3 chunks +1 line, -5 lines 0 comments Download
M remoting/android/host/AndroidManifest.xml View 1 chunk +0 lines, -4 lines 0 comments Download
M remoting/android/host/res/layout/main.xml View 1 chunk +0 lines, -6 lines 0 comments Download
M remoting/android/host/src/org/chromium/chromoting/host/MainActivity.java View 2 chunks +0 lines, -56 lines 0 comments Download
M remoting/android/host/src/org/chromium/chromoting/host/jni/Host.java View 1 chunk +0 lines, -12 lines 0 comments Download
M remoting/host/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M remoting/host/android/jni_host.h View 1 chunk +2 lines, -38 lines 0 comments Download
M remoting/host/android/jni_host.cc View 2 chunks +1 line, -91 lines 0 comments Download
M remoting/host/it2me/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M remoting/host/policy_watcher.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jbudorick
Created Revert of [remoting android] Initialize It2Me host and implement Connect()
4 years, 8 months ago (2016-04-22 02:43:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913023002/1
4 years, 8 months ago (2016-04-22 02:43:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 02:44:32 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:43:26 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58294a735594816eb0110d0248c8282d9c1a4ae8
Cr-Commit-Position: refs/heads/master@{#389001}

Powered by Google App Engine
This is Rietveld 408576698