MacViews: Implement NSResponder deletion action messages.

ui/views/cocoa/bridged_content_view.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ui/views/cocoa/bridged_content_view.h"
 
 #include "base/logging.h"
 #import "base/mac/mac_util.h"
 #import "base/mac/scoped_nsobject.h"
 #include "base/strings/sys_string_conversions.h"
@@ skipping 675 matching lines @@
 }
 
 - (void)deleteBackward:(id)sender {
   [self handleAction:IDS_DELETE_BACKWARD
              keyCode:ui::VKEY_BACK
              domCode:ui::DomCode::BACKSPACE
           eventFlags:0];
 }
 
 - (void)deleteWordForward:(id)sender {
-  [self handleAction:IDS_DELETE_WORD_FORWARD
+  // In case of a non-empty selection, delete the selection.
+  int command = [self selectedRange].length ? IDS_DELETE_FORWARD

[karandeepb, 2016/04/22 02:02:46]

For other platforms, this case is handled in
Textfield::GetCommandForKeyEvent(..). But since on Linux and Mac, we may bypass
GetCommandForKeyEvent(), it causes crbug.com/605492. Another approach can be to
have GetCommandForKeyEvent just map the event to appropriate command, without
considering selection etc. Then ExecuteCommand can take care of the selection
case. This should also fix this bug on Linux. 

[tapted, 2016/04/26 05:46:54]

Yeah I like the idea of moving this into ExecuteCommand - it would simplify
things here, and in GetCommandForKeyEvent, as well as fix this bug on linux. It
should be a separate CL though.

[karandeepb, 2016/04/29 01:52:48]

Done. CL here - https://codereview.chromium.org/1923793002

+                                            : IDS_DELETE_WORD_FORWARD;
+  [self handleAction:command
              keyCode:ui::VKEY_DELETE
              domCode:ui::DomCode::DEL
           eventFlags:ui::EF_CONTROL_DOWN];
 }
 
 - (void)deleteWordBackward:(id)sender {
-  [self handleAction:IDS_DELETE_WORD_BACKWARD
+  // In case of a non-empty selection, delete the selection.
+  int command = [self selectedRange].length ? IDS_DELETE_BACKWARD
+                                            : IDS_DELETE_WORD_BACKWARD;
+  [self handleAction:command
              keyCode:ui::VKEY_BACK
              domCode:ui::DomCode::BACKSPACE
           eventFlags:ui::EF_CONTROL_DOWN];
 }
 
+- (void)deleteToBeginningOfLine:(id)sender {
+  // In case of a non-empty selection, delete the selection.
+  int command = [self selectedRange].length ? IDS_DELETE_BACKWARD
+                                            : IDS_DELETE_TO_BEGINNING_OF_LINE;
+  [self handleAction:command
+             keyCode:ui::VKEY_BACK
+             domCode:ui::DomCode::BACKSPACE
+          eventFlags:ui::EF_CONTROL_DOWN | ui::EF_SHIFT_DOWN];
+}
+
+- (void)deleteToEndOfLine:(id)sender {
+  // In case of a non-empty selection, delete the selection.
+  int command = [self selectedRange].length ? IDS_DELETE_FORWARD
+                                            : IDS_DELETE_TO_END_OF_LINE;
+  [self handleAction:command
+             keyCode:ui::VKEY_DELETE
+             domCode:ui::DomCode::DEL
+          eventFlags:ui::EF_CONTROL_DOWN | ui::EF_SHIFT_DOWN];
+}
+
+- (void)deleteToBeginningOfParagraph:(id)sender {
+  // Since we currently only support single line textfields, forward the action

[tapted, 2016/04/26 05:46:54]

Generally it's bad to repeat comments - just like code - since updating multiple
places when things get out of date is annoying.

I'd go for something like

// views::Textfields are single-line only, map Paragraph and Document commands
to Line.

"Document" you say? Yep! we should include ..Beginning/End of Document as well.

We should also include the moveTo* and the moveTo..AndModifySelection commands
with this CL, since they all fall under the bag of "must map them to line"

[karandeepb, 2016/04/29 01:52:48]

Done. If it's ok, will add the movement commands in a separate CL, since there
are a lot of them.

+  // message to deleteToBeginningOfLine:.
+  [self deleteToBeginningOfLine:sender];
+}
+
+- (void)deleteToEndOfParagraph:(id)sender {
+  // Since we currently only support single line textfields, forward the action
+  // message to deleteToEndOfLine:.
+  [self deleteToEndOfLine:sender];
+}
+
 // Cancellation.
 
 - (void)cancelOperation:(id)sender {
   [self handleAction:0
              keyCode:ui::VKEY_ESCAPE
              domCode:ui::DomCode::ESCAPE
           eventFlags:0];
 }
 
 // Support for Services in context menus.
@@ skipping 208 matching lines @@
   }
 
   return [super accessibilityAttributeValue:attribute];
 }
 
 - (id)accessibilityHitTest:(NSPoint)point {
   return [hostedView_->GetNativeViewAccessible() accessibilityHitTest:point];
 }
 
 @end