Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1912983002: Add pretty-printing for SETTINGS messages. (Closed)

Created:
4 years, 8 months ago by Wez
Modified:
4 years, 8 months ago
Reviewers:
Khushal
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add pretty-printing for SETTINGS messages. This was missed from issue 1810213009, which added them to the protocol. BUG=591575 Committed: https://crrev.com/498195618ff83fc35e096685d07a9f28cd6cadff Cr-Commit-Position: refs/heads/master@{#389019}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -70 lines) Patch
M blimp/common/logging.cc View 4 chunks +87 lines, -70 lines 0 comments Download
M blimp/common/logging_unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Wez
PTAL
4 years, 8 months ago (2016-04-22 01:26:20 UTC) #2
Khushal
lgtm. Thanks!
4 years, 8 months ago (2016-04-22 01:32:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912983002/1
4 years, 8 months ago (2016-04-22 01:43:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 04:05:13 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:44:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/498195618ff83fc35e096685d07a9f28cd6cadff
Cr-Commit-Position: refs/heads/master@{#389019}

Powered by Google App Engine
This is Rietveld 408576698