[DevTools] JSONView parsing smarter

third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 37 matching lines @@
                 this._emptyWidget = this._createEmptyWidget();
                 this._emptyWidget.show(this.element);
                 this.innerView = this._emptyWidget;
             }
         } else {
             if (this._emptyWidget) {
                 this._emptyWidget.detach();
                 delete this._emptyWidget;
             }
 
-            if (!this._previewView) {
-                this._previewView = this._createPreviewView();
-                this._previewView.show(this.element);
-                if (this._previewView instanceof WebInspector.VBoxWithToolbarItems) {
-                    var toolbar = new WebInspector.Toolbar("network-item-preview-toolbar", this.element);
-                    for (var item of /** @type {!WebInspector.VBoxWithToolbarItems} */ (this._previewView).toolbarItems())
-                        toolbar.appendToolbarItem(item);
-                }
+            if (!this._previewView)
+                this._createPreviewView(handlePreviewView.bind(this));
+            else
+                this.innerView = this._previewView;
+        }
+
+        /**
+         * @param {!WebInspector.Widget} view
+         * @this {WebInspector.RequestPreviewView}
+         */
+        function handlePreviewView(view) {
+            this._previewView = view;
+            this._previewView.show(this.element);
+            if (this._previewView instanceof WebInspector.VBoxWithToolbarItems) {
+                var toolbar = new WebInspector.Toolbar("network-item-preview-toolbar", this.element);
+                for (var item of /** @type {!WebInspector.VBoxWithToolbarItems} */ (this._previewView).toolbarItems())
+                    toolbar.appendToolbarItem(item);
             }
             this.innerView = this._previewView;
         }
     },
 
     _createEmptyWidget: function()
     {
         return this._createMessageView(WebInspector.UIString("This request has no preview available."));
     },
 
     /**
      * @param {string} message
      * @return {!WebInspector.EmptyWidget}
      */
     _createMessageView: function(message)
     {
         return new WebInspector.EmptyWidget(message);
     },
 
     /**
      * @return {string}
      */
     _requestContent: function()
     {
         var content = this.request.content;
         return this.request.contentEncoded ? window.atob(content || "") : (content || "");
     },
 
     /**
+     * @param {?WebInspector.ParsedJSON} parsedJSON
      * @return {?WebInspector.JSONView}
      */
-    _jsonView: function()
+    _jsonView: function(parsedJSON)
     {
-        var parsedJSON = WebInspector.JSONView.parseJSON(this._requestContent());
-        return parsedJSON && new WebInspector.JSONView(parsedJSON);
+        if (!parsedJSON || typeof parsedJSON.data !== "object")
+            return null;
+        return new WebInspector.JSONView(/** @type {!WebInspector.ParsedJSON} */ (parsedJSON));
     },
 
     /**
      * @return {?WebInspector.XMLView}
      */
     _xmlView: function()
     {
         var content = this._requestContent();
         var parsedXML = WebInspector.XMLView.parseXML(content, this.request.mimeType);
         return parsedXML ? new WebInspector.XMLView(parsedXML) : null;
     },
 
     /**
      * @return {?WebInspector.RequestHTMLView}
      */
     _htmlErrorPreview: function()
     {
         var whitelist = ["text/html", "text/plain", "application/xhtml+xml"];
         if (whitelist.indexOf(this.request.mimeType) === -1)
             return null;
 
         var dataURL = this.request.asDataURL();
         if (dataURL === null)
             return null;
 
         return new WebInspector.RequestHTMLView(this.request, dataURL);
     },
 
-    _createPreviewView: function()
+    /**
+     * @param {function(!WebInspector.Widget)} callback
+     */
+    _createPreviewView: function(callback)
     {
-        if (this.request.contentError())
-            return this._createMessageView(WebInspector.UIString("Failed to load response data"));
-
-        var mimeType = this.request.mimeType || "";
-        if (mimeType.endsWith("json") || mimeType.endsWith("javascript")) {
-            var jsonView = this._jsonView();
-            if (jsonView)
-                return jsonView;
-        }
-
-        if (this.request.hasErrorStatusCode()) {
-            var htmlErrorPreview = this._htmlErrorPreview();
-            if (htmlErrorPreview)
-                return htmlErrorPreview;
+        if (this.request.contentError()) {
+            callback(this._createMessageView(WebInspector.UIString("Failed to load response data")));
+            return;
         }
 
         var xmlView = this._xmlView();
         if (xmlView)
             return xmlView;
 
-        if (this.request.resourceType() === WebInspector.resourceTypes.XHR) {
-            var jsonView = this._jsonView();
-            if (jsonView)
-                return jsonView;
-            var htmlErrorPreview = this._htmlErrorPreview();
-            if (htmlErrorPreview)
-                return htmlErrorPreview;
+        WebInspector.JSONView.parseJSON(this._requestContent()).then(chooseView.bind(this)).then(callback);
+
+        /**
+         * @this {WebInspector.RequestPreviewView}
+         * @param {?WebInspector.ParsedJSON} jsonData
+         * @return {!WebInspector.Widget}
+         */
+        function chooseView(jsonData)
+        {
+            if (jsonData) {
+                var jsonView = this._jsonView(jsonData);
+                if (jsonView)
+                    return jsonView;
+            }
+
+            if (this.request.hasErrorStatusCode() || this.request.resourceType() === WebInspector.resourceTypes.XHR) {
+                var htmlErrorPreview = this._htmlErrorPreview();
+                if (htmlErrorPreview)
+                    return htmlErrorPreview;
+            }
+
+            if (this._responseView.sourceView)
+                return this._responseView.sourceView;
+
+            if (this.request.resourceType() === WebInspector.resourceTypes.Other)
+                return this._createEmptyWidget();
+
+            return WebInspector.RequestView.nonSourceViewForRequest(this.request);
         }
-
-        if (this._responseView.sourceView)
-            return this._responseView.sourceView;
-
-        if (this.request.resourceType() === WebInspector.resourceTypes.Other)
-            return this._createEmptyWidget();
-
-        return WebInspector.RequestView.nonSourceViewForRequest(this.request);
     },
 
     __proto__: WebInspector.RequestContentView.prototype
 }