Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 191293012: Reland "Handle non-power-of-2 divisors in division-like operations". (Closed)

Created:
6 years, 9 months ago by Benedikt Meurer
Modified:
6 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Reland "Handle non-power-of-2 divisors in division-like operations". Fixed the flooring div bug and added a test case. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19749

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+962 lines, -357 lines) Patch
M src/a64/lithium-a64.h View 7 chunks +65 lines, -0 lines 0 comments Download
M src/a64/lithium-a64.cc View 9 chunks +72 lines, -12 lines 0 comments Download
M src/a64/lithium-codegen-a64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/a64/lithium-codegen-a64.cc View 4 chunks +91 lines, -0 lines 0 comments Download
M src/a64/macro-assembler-a64.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/a64/macro-assembler-a64.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M src/arm/lithium-arm.h View 6 chunks +48 lines, -6 lines 0 comments Download
M src/arm/lithium-arm.cc View 7 chunks +58 lines, -38 lines 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 chunk +0 lines, -11 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 4 chunks +76 lines, -154 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M src/assembler.h View 1 chunk +15 lines, -0 lines 0 comments Download
M src/assembler.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 4 chunks +70 lines, -45 lines 0 comments Download
M src/ia32/lithium-ia32.h View 6 chunks +63 lines, -4 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 5 chunks +71 lines, -9 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/utils.h View 1 chunk +0 lines, -26 lines 0 comments Download
M src/utils.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 3 chunks +71 lines, -27 lines 0 comments Download
M src/x64/lithium-x64.h View 6 chunks +63 lines, -4 lines 0 comments Download
M src/x64/lithium-x64.cc View 5 chunks +68 lines, -7 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M test/mjsunit/math-floor-of-div.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
6 years, 9 months ago (2014-03-10 10:38:09 UTC) #1
Sven Panne
lgtm
6 years, 9 months ago (2014-03-10 10:38:50 UTC) #2
Benedikt Meurer
6 years, 9 months ago (2014-03-10 10:39:37 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r19749 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698