Source/core/html/shadow/DateTimeFieldElement.h - Issue 191293011: Value set in onblur should not keep element in focus

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/shadow/DateTimeFieldElement.h

Issue 191293011: Value set in onblur should not keep element in focus (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: SetFocus handler implementation for DateTimeFieldElement Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-onblur-setvalue-onfocusremoved.html ('K') | « LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-onblur-setvalue-onfocusremoved-expected.txt ('k') | Source/core/html/shadow/DateTimeFieldElement.cpp » ('j') | Source/core/html/shadow/DateTimeFieldElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/shadow/DateTimeFieldElement.h

diff --git a/Source/core/html/shadow/DateTimeFieldElement.h b/Source/core/html/shadow/DateTimeFieldElement.h

index 66ff3b7918420bd95c5a121a1cdfc86e74b0e66e..94812f1f3795af5adeec3e017370618c01039910 100644

--- a/Source/core/html/shadow/DateTimeFieldElement.h

+++ b/Source/core/html/shadow/DateTimeFieldElement.h

@@ -79,8 +79,7 @@ public:

protected:

DateTimeFieldElement(Document&, FieldOwner&);

- virtual void didBlur();

- virtual void didFocus();

+ virtual void setFocus(bool) OVERRIDE;

void focusOnNextField();

virtual void handleKeyboardEvent(KeyboardEvent*) = 0;

void initialize(const AtomicString& pseudo, const String& axHelpText, int axMinimum, int axMaximum);

@@ -96,7 +95,6 @@ private:

bool isFieldOwnerDisabled() const;

bool isFieldOwnerReadOnly() const;

virtual bool supportsFocus() const OVERRIDE FINAL;

tkent 2014/03/31 04:17:08 nit: Please do not remove the blank line. We usua

Habib Virji 2014/03/31 09:05:51 Done.

FieldOwner* m_fieldOwner;

};