Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 191293009: Cleanup: Move kAboutScheme constant into content namespace. (Closed)

Created:
6 years, 9 months ago by tfarina
Modified:
6 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, jam, creis+watch_chromium.org, tfarina, nasko+codewatch_chromium.org, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, markusheintz_, James Su, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Cleanup: Move kAboutScheme constant into content namespace. This moves the last constant from chrome to content namespace and fixes the John's TODO. $ git grep "namespace chrome" content/ returns 0 entries. BUG=None TEST=None, no functional changes TBR=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256015

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -39 lines) Patch
M android_webview/renderer/aw_content_renderer_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/builtin_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/builtin_provider_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/browsing_data_helper_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_permissions.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/history/history_backend.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/in_memory_url_index.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/toolbar/origin_chip_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/net/url_fixer_upper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/importer/bookmarks_file_importer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/child_process_security_policy_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/child_process_security_policy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/url_constants.h View 1 chunk +1 line, -6 lines 0 comments Download
M content/public/common/url_constants.cc View 1 chunk +1 line, -6 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
tfarina
TBRing...
6 years, 9 months ago (2014-03-10 01:10:26 UTC) #1
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 9 months ago (2014-03-10 01:10:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/191293009/1
6 years, 9 months ago (2014-03-10 01:10:42 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-10 06:21:18 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=278431
6 years, 9 months ago (2014-03-10 06:21:18 UTC) #5
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 9 months ago (2014-03-10 13:52:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/191293009/1
6 years, 9 months ago (2014-03-10 13:53:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/191293009/1
6 years, 9 months ago (2014-03-10 14:27:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/191293009/1
6 years, 9 months ago (2014-03-10 15:52:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/191293009/1
6 years, 9 months ago (2014-03-10 17:39:18 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 20:08:45 UTC) #11
Message was sent while issue was closed. 
Change committed as 256015

Powered by Google App Engine
This is Rietveld 408576698