Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 191293006: Move GetContextMenuNode from RenderView to RenderFrame. (Closed)

Created:
6 years, 9 months ago by jam
Modified:
6 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : sync and fix android clang error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -128 lines) Patch
M android_webview/android_webview.gyp View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M android_webview/common/print_messages.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/renderer/aw_content_renderer_client.cc View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
A android_webview/renderer/aw_render_frame_observer.h View 1 1 chunk +31 lines, -0 lines 0 comments Download
A android_webview/renderer/aw_render_frame_observer.cc View 1 2 3 4 1 chunk +38 lines, -0 lines 0 comments Download
M android_webview/renderer/print_web_view_helper.h View 1 2 3 4 3 chunks +4 lines, -19 lines 0 comments Download
M android_webview/renderer/print_web_view_helper.cc View 1 2 3 4 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 2 3 4 2 chunks +13 lines, -7 lines 0 comments Download
M chrome/common/print_messages.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_render_frame_observer.h View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_render_frame_observer.cc View 1 2 3 4 3 chunks +88 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 1 2 3 4 4 chunks +0 lines, -55 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper.h View 1 2 3 4 3 chunks +4 lines, -19 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper.cc View 1 2 3 4 2 chunks +0 lines, -6 lines 0 comments Download
M content/public/renderer/render_frame.h View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M content/public/renderer/render_view.h View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
sgurun: FYI for android_webview. The forked code only has the renderer-side, the browser will need ...
6 years, 9 months ago (2014-03-10 14:40:37 UTC) #1
sgurun-gerrit only
On 2014/03/10 14:40:37, jam wrote: > sgurun: FYI for android_webview. The forked code only has ...
6 years, 9 months ago (2014-03-10 16:44:17 UTC) #2
nasko
LGTM
6 years, 9 months ago (2014-03-10 17:00:22 UTC) #3
sgurun-gerrit only
On 2014/03/10 17:00:22, nasko wrote: > LGTM added boliu for aw owner's stamp.
6 years, 9 months ago (2014-03-10 17:02:58 UTC) #4
boliu
6 years, 9 months ago (2014-03-10 17:46:57 UTC) #5 
On 2014/03/10 17:02:58, sgurun wrote:
> On 2014/03/10 17:00:22, nasko wrote:
> > LGTM
> 
> added boliu for aw owner's stamp.

lgtm

Powered by Google App Engine
This is Rietveld 408576698