Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 191293004: cc: Rename FinishCommit to NotifyReadyToCommit (Closed)

Created:
6 years, 9 months ago by simonhong
Modified:
6 years, 9 months ago
Reviewers:
brianderson
CC:
chromium-reviews, cc-bugs_chromium.org, hyojun.im_lge.com
Visibility:
Public.

Description

cc: Rename FinishCommit to NotifyReadyToCommit FinishCommit() is used to inform that painting is complete and we can ready to commit to scheduler. So, NotifyReadyToCommit() is more suitable for its role. R=brianderson@chromium.org BUG=349889 TEST=None (No functional change) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255895

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -47 lines) Patch
M cc/scheduler/scheduler.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/scheduler/scheduler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/scheduler/scheduler_state_machine_unittest.cc View 22 chunks +22 lines, -22 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 14 chunks +18 lines, -18 lines 0 comments Download
M cc/trees/thread_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
simonhong
PTAL!
6 years, 9 months ago (2014-03-07 22:27:35 UTC) #1
brianderson
Thank you. lgtm.
6 years, 9 months ago (2014-03-07 22:31:16 UTC) #2
simonhong
The CQ bit was checked by simonhong@chromium.org
6 years, 9 months ago (2014-03-07 22:43:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhong@chromium.org/191293004/1
6 years, 9 months ago (2014-03-07 22:44:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhong@chromium.org/191293004/1
6 years, 9 months ago (2014-03-08 11:08:06 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 14:00:01 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234345
6 years, 9 months ago (2014-03-08 14:00:02 UTC) #7
simonhong
The CQ bit was checked by simonhong@chromium.org
6 years, 9 months ago (2014-03-08 14:18:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhong@chromium.org/191293004/1
6 years, 9 months ago (2014-03-08 14:18:43 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 14:54:58 UTC) #10
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234399
6 years, 9 months ago (2014-03-08 14:54:59 UTC) #11
simonhong
The CQ bit was checked by simonhong@chromium.org
6 years, 9 months ago (2014-03-08 22:00:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhong@chromium.org/191293004/1
6 years, 9 months ago (2014-03-08 22:00:27 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 22:48:25 UTC) #14
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234603
6 years, 9 months ago (2014-03-08 22:48:25 UTC) #15
simonhong
The CQ bit was checked by simonhong@chromium.org
6 years, 9 months ago (2014-03-09 19:13:24 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhong@chromium.org/191293004/1
6 years, 9 months ago (2014-03-09 19:13:28 UTC) #17
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 07:11:28 UTC) #18
Message was sent while issue was closed. 
Change committed as 255895

Powered by Google App Engine
This is Rietveld 408576698