Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1912923003: Check for semaphore alignment on posix platforms. (Closed)

Created:
4 years, 8 months ago by ulan
Modified:
4 years, 8 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Check for semaphore alignment on posix platforms. BUG=chromium:605349 LOG=NO Committed: https://crrev.com/8d24472acfaf7e67ca20106cb1f405fc0590c849 Cr-Commit-Position: refs/heads/master@{#35717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/base/platform/semaphore.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ulan
PTAL
4 years, 8 months ago (2016-04-22 09:19:00 UTC) #2
Michael Lippautz
lgtm
4 years, 8 months ago (2016-04-22 09:21:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912923003/1
4 years, 8 months ago (2016-04-22 09:21:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 10:14:56 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8d24472acfaf7e67ca20106cb1f405fc0590c849 Cr-Commit-Position: refs/heads/master@{#35717}
4 years, 8 months ago (2016-04-22 19:15:12 UTC) #8
Michael Hablich
4 years, 8 months ago (2016-04-25 08:59:02 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1921533002/ by hablich@chromium.org.

The reason for reverting is: blocks rolling. See
https://bugs.chromium.org/p/chromium/issues/detail?id=605349 for more
information.

This CL only triggers the problem earlier but is not the culprit.

The real bug is under investigation by the GC team..

Powered by Google App Engine
This is Rietveld 408576698