Add media_features deps in media.gyp and media/base/BUILD.gn

Add media_features deps in media.gyp and media/base/BUILD.gn

Now that media_features.h header is included in video_decoder_config.h
we need more targets to explicitly depend on media_features.h

BUG=605700
TBR=xhwang@chromium.org, wolenetz@chromium.org

Committed: https://crrev.com/e61bb2a62e968b6c2e4149e269ae38259a760203
Cr-Commit-Position: refs/heads/master@{#388940}

[servolk, 2016-04-21 23:02:00]

Description was changed from

==========
Add media_features deps in media.gyp and media/base/BUILD.gn

Now that media_features.h header is included in video_decoder_config.h
we need more targets to explicitly depend on media_features.h

BUG=605700
==========

to

==========
Add media_features deps in media.gyp and media/base/BUILD.gn

Now that media_features.h header is included in video_decoder_config.h
we need more targets to explicitly depend on media_features.h

BUG=605700
==========

[servolk, 2016-04-21 23:02:00]

servolk@chromium.org changed reviewers:
+ wolenetz@chromium.org, xhwang@chromium.org

[servolk, 2016-04-21 23:02:17]

On 2016/04/21 23:02:00, servolk wrote:
> mailto:servolk@chromium.org changed reviewers:
> + mailto:wolenetz@chromium.org, mailto:xhwang@chromium.org

See https://codereview.chromium.org/1907003002/#msg17 for more context

[japacible, 2016-04-21 23:06:19]

Description was changed from

==========
Add media_features deps in media.gyp and media/base/BUILD.gn

Now that media_features.h header is included in video_decoder_config.h
we need more targets to explicitly depend on media_features.h

BUG=605700
==========

to

==========
Add media_features deps in media.gyp and media/base/BUILD.gn

Now that media_features.h header is included in video_decoder_config.h
we need more targets to explicitly depend on media_features.h

BUG=605700
TBR=xhwang@chromium.org, wolenetz@chromium.org
==========

[apacible, 2016-04-21 23:10:16]

Description was changed from

==========
Add media_features deps in media.gyp and media/base/BUILD.gn

Now that media_features.h header is included in video_decoder_config.h
we need more targets to explicitly depend on media_features.h

BUG=605700
TBR=xhwang@chromium.org, wolenetz@chromium.org
==========

to

==========
Add media_features deps in media.gyp and media/base/BUILD.gn

Now that media_features.h header is included in video_decoder_config.h
we need more targets to explicitly depend on media_features.h

BUG=605700
TBR=xhwang@chromium.org, wolenetz@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/e61bb2a62e968b6c2e4149e269ae...
==========

[apacible, 2016-04-21 23:10:17]

Committed patchset #1 (id:1) manually as
e61bb2a62e968b6c2e4149e269ae38259a760203 (presubmit successful).

[wolenetz, 2016-04-21 23:29:15]

aside: My GYP fu is outdated a bit. Do we need to declare explicitly all our
dependencies for each target, or can some be transitive? I see we've previously
taken both media and media_test_support dependencies in targets previously, and
media_test_support itself depends on media: is that intentional?

https://codereview.chromium.org/1912923002/diff/1/media/media.gyp
File media/media.gyp (right):

https://codereview.chromium.org/1912923002/diff/1/media/media.gyp#newcode1105
media/media.gyp:1105: 'media_features',
Is this explicitly necessary, since media_test_support contains it now in this
CL, too?

https://codereview.chromium.org/1912923002/diff/1/media/media.gyp#newcode1382
media/media.gyp:1382: 'media_features',
ditto

[servolk, 2016-04-22 18:46:24]

https://codereview.chromium.org/1912923002/diff/1/media/media.gyp
File media/media.gyp (right):

https://codereview.chromium.org/1912923002/diff/1/media/media.gyp#newcode1105
media/media.gyp:1105: 'media_features',
On 2016/04/21 23:29:15, wolenetz wrote:
> Is this explicitly necessary, since media_test_support contains it now in this
> CL, too?

I assumed that it wasn't necessary, since I thought the dependencies were
transitive (and media already depends on media_features), but somehow without
this explicit dependency the Win build on trunk was broken. With this explicit
dependency the build is green an all platforms. So let's keep it for now, there
should be no harm in it (since, as I've said media already depends on
media_features anyway, and all the targets changed here already have a
dependency on media target). Hopefully GYP days are counted and we'll all just
switch to GN soon.

https://codereview.chromium.org/1912923002/diff/1/media/media.gyp#newcode1382
media/media.gyp:1382: 'media_features',
On 2016/04/21 23:29:15, wolenetz wrote:
> ditto

Acknowledged.

[commit-bot: I haz the power, 2016-04-22 19:41:10]

Description was changed from

==========
Add media_features deps in media.gyp and media/base/BUILD.gn

Now that media_features.h header is included in video_decoder_config.h
we need more targets to explicitly depend on media_features.h

BUG=605700
TBR=xhwang@chromium.org, wolenetz@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/e61bb2a62e968b6c2e4149e269ae...
==========

to

==========
Add media_features deps in media.gyp and media/base/BUILD.gn

Now that media_features.h header is included in video_decoder_config.h
we need more targets to explicitly depend on media_features.h

BUG=605700
TBR=xhwang@chromium.org, wolenetz@chromium.org

Committed: https://crrev.com/e61bb2a62e968b6c2e4149e269ae38259a760203
Cr-Commit-Position: refs/heads/master@{#388940}
==========

[commit-bot: I haz the power, 2016-04-22 19:41:11]

Patchset 1 (id:??) landed as
https://crrev.com/e61bb2a62e968b6c2e4149e269ae38259a760203
Cr-Commit-Position: refs/heads/master@{#388940}