cc : Stop pushing properties not used by LayerImpl to LayerImpl. (2)

cc/layers/layer.h

 // Copyright 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_LAYERS_LAYER_H_
 #define CC_LAYERS_LAYER_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 469 matching lines @@
   // a Commit. This is called right after property tree being built and should
   // not trigger property tree rebuild.
   void SetHasRenderSurface(bool has_render_surface);
   bool has_render_surface() const {
     return has_render_surface_;
   }
 
   void SetSubtreePropertyChanged();
   bool subtree_property_changed() const { return subtree_property_changed_; }
 
+  void SetLayerPropertyChanged();
+  bool layer_property_changed() const { return layer_property_changed_; }

[ajuma, 2016/04/21 23:59:14]

There aren't any real non-test callers of SetForceRenderSurface. It's exposed on
WebLayer and ui::Layer but not used in a non-trivial way (ui::Layer uses it in a
test, but that can be deleted). What if we remove
WebLayer::setForceRenderSurface and ui::Layer::SetForceRenderSurface, and rename
the cc::Layer method to SetForRenderSurfaceForTesting? Then we don't need to add
or push this layer_property_changed_ bool (since any tests that depend on
SetForceRenderSurface to cause damage should be changed to not depend on this).
Does that seem reasonable?

[jaydasika, 2016/04/22 17:00:38]

Done.

+
   void DidBeginTracing();
 
   int num_copy_requests_in_target_subtree();
 
   void SetElementId(uint64_t id);
   uint64_t element_id() const { return element_id_; }
 
   void SetMutableProperties(uint32_t properties);
   uint32_t mutable_properties() const { return mutable_properties_; }
 
@@ skipping 136 matching lines @@
   bool contents_opaque_ : 1;
   bool double_sided_ : 1;
   bool should_flatten_transform_ : 1;
   bool use_parent_backface_visibility_ : 1;
   bool use_local_transform_for_backface_visibility_ : 1;
   bool should_check_backface_visibility_ : 1;
   bool force_render_surface_ : 1;
   bool transform_is_invertible_ : 1;
   bool has_render_surface_ : 1;
   bool subtree_property_changed_ : 1;
+  bool layer_property_changed_ : 1;
   Region non_fast_scrollable_region_;
   Region touch_event_handler_region_;
   gfx::PointF position_;
   SkColor background_color_;
   SkColor safe_opaque_background_color_;
   float opacity_;
   SkXfermode::Mode blend_mode_;
   // draw_blend_mode may be different than blend_mode_,
   // when a RenderSurface re-parents the layer's blend_mode.
   SkXfermode::Mode draw_blend_mode_;
@@ skipping 23 matching lines @@
   // These all act like draw properties, so don't need push properties.
   gfx::Rect visible_layer_rect_;
   size_t num_unclipped_descendants_;
 
   DISALLOW_COPY_AND_ASSIGN(Layer);
 };
 
 }  // namespace cc
 
 #endif  // CC_LAYERS_LAYER_H_