Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 1912873002: Update the comments related to the host window in SelectFileDialogImplGTK (Closed)

Created:
4 years, 8 months ago by joone
Modified:
4 years, 8 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the comments related to the host window in SelectFileDialogImplGTK The comments need to be updated due to following reasons: 1. The bug mentioned in the comment cannot be reproducible. http://crbug.com/29213 2. AllBrowsersClosed() method was removed in the below CL, but it is still mentioned. https://codereview.chromium.org/231733005 3. The second case that |parent| is null is obsolete. BUG=None Committed: https://crrev.com/88ab2806cb68a0d3013ab7f9a215145e3ab1ee68 Cr-Commit-Position: refs/heads/master@{#388952}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc View 2 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
joone
Hi erg@, can you take a look at this CL?
4 years, 8 months ago (2016-04-21 21:59:27 UTC) #2
Elliot Glaysher
lgtm
4 years, 8 months ago (2016-04-21 22:24:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912873002/1
4 years, 8 months ago (2016-04-21 22:26:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 23:39:16 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:41:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88ab2806cb68a0d3013ab7f9a215145e3ab1ee68
Cr-Commit-Position: refs/heads/master@{#388952}

Powered by Google App Engine
This is Rietveld 408576698