third_party/WebKit/LayoutTests/fast/images/imagemap-focus-ring-in-positioned-container.html - Issue 1912863002: Fix image map focus ring painting

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/images/imagemap-focus-ring-in-positioned-container.html

Issue 1912863002: Fix image map focus ring painting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/fast/images/imagemap-focus-ring-in-positioned-container-expected.png » ('j') | third_party/WebKit/Source/modules/accessibility/AXImageMapLink.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	pdr. 2016/04/23 03:32:22 Is it possible to test these with reftests instead Is it possible to test these with reftests instead of pixel tests? imagemap-focus-ring-zoom-style-expected.html looks like one example that does this. Xianzhu 2016/04/25 23:18:15 Converted 2 of the 3 tests into reftests. Not usin Show quoted text On 2016/04/23 03:32:22, pdr wrote: > Is it possible to test these with reftests instead of pixel tests? > imagemap-focus-ring-zoom-style-expected.html looks like one example that does > this. Converted 2 of the 3 tests into reftests. Not using reftest for the remaining one (with-transform) because I can't avoid small pixel differences except I also use transform in the reference which will reduce the test coverage (because the test and the ref use too much the same code path).
	2 <style>

	3 .container {

	4 position: absolute;

	5 left: 20px;

	6 top: 50px;

	7 }

	8 .inner {

	9 position: absolute;

	10 left: 10px;

	11 top: 10px;

	12 }

	13 </style>

	14 <script>

	15 window.onload = function() {
	pdr. 2016/04/23 03:40:54 Nit: No need for onload here, you can just put the Nit: No need for onload here, you can just put the following at the bottom of this file: <script> area.focus(); </script> Xianzhu 2016/04/25 23:18:15 Done but still use document.getElementById('area') Show quoted text On 2016/04/23 03:40:54, pdr wrote: > Nit: No need for onload here, you can just put the following at the bottom of > this file: > <script> > area.focus(); > </script> Done but still use document.getElementById('area'). Just curious about the usage of "area" instead of "document.getElementById('area')". Is this a part of open web API of chrome?
	16 document.getElementById("area").focus();

	17 }

	18 </script>

	19 Tests that we paint area outline properly when the image is inside positioned co ntainers.

	20 <div class=container>

	21 <div class=inner>

	22 <img src="./resources/green.jpg" width=50 height=50 usemap="#map"/>

	23 <map name="map"><area id=area shape="rectangle" coords="5, 5, 25, 25" href=" #"></map>

	24 </div>

	25 </div>

OLD	NEW