Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 1912853003: [turbofan] Add the Verifier to the pipeline for code stubs. (Closed)

Created:
4 years, 8 months ago by epertoso
Modified:
4 years, 8 months ago
Reviewers:
Jarin, *rmcilroy
CC:
oth, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add the Verifier to the pipeline for code stubs. Removes some control edges added from the RawMachineAssembler to the end of the graph. Adds a parameter that tells the Verifier to ignore effect and control inputs. Committed: https://crrev.com/339000bf3bcdc3f07f36b978807a35d88659b58c Cr-Commit-Position: refs/heads/master@{#35731}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -128 lines) Patch
M src/compiler/pipeline.cc View 3 chunks +11 lines, -3 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 9 chunks +0 lines, -9 lines 0 comments Download
M src/compiler/verifier.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/verifier.cc View 4 chunks +25 lines, -19 lines 0 comments Download
M src/interpreter/interpreter-assembler.h View 3 chunks +10 lines, -10 lines 0 comments Download
M src/interpreter/interpreter-assembler.cc View 6 chunks +13 lines, -13 lines 0 comments Download
M test/unittests/interpreter/interpreter-assembler-unittest.cc View 4 chunks +4 lines, -73 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
epertoso
4 years, 8 months ago (2016-04-22 13:04:00 UTC) #3
Jarin
lgtm (for the src/compiler changes).
4 years, 8 months ago (2016-04-22 13:07:22 UTC) #4
epertoso
Adding rmcilroy@ for the interpreter-related changes.
4 years, 8 months ago (2016-04-22 13:12:07 UTC) #7
rmcilroy
Interpreter changes LGTM.
4 years, 8 months ago (2016-04-22 13:21:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912853003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912853003/20001
4 years, 8 months ago (2016-04-22 13:32:16 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 8 months ago (2016-04-22 13:55:59 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:15:41 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/339000bf3bcdc3f07f36b978807a35d88659b58c
Cr-Commit-Position: refs/heads/master@{#35731}

Powered by Google App Engine
This is Rietveld 408576698