Issue 191283002: A64: UseRegisterAtStart for rhs of LMulS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 191283002: A64: UseRegisterAtStart for rhs of LMulS (Closed)

Created:
6 years, 9 months ago by m.m.capewell

Modified:
6 years, 9 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

A64: UseRegisterAtStart for rhs of LMulS BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19814

Patch Set 1 #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -8 lines)			Patch
	M	src/a64/lithium-a64.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	src/a64/lithium-codegen-a64.cc	View		3 chunks	+20 lines, -6 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

lgtm https://codereview.chromium.org/191283002/diff/1/src/a64/lithium-codegen-a64.cc File src/a64/lithium-codegen-a64.cc (right): https://codereview.chromium.org/191283002/diff/1/src/a64/lithium-codegen-a64.cc#newcode4294 src/a64/lithium-codegen-a64.cc:4294: } else { ASSERT(!left.Is(result));

6 years, 9 months ago (2014-03-11 13:39:13 UTC) #2

m.m.capewell

6 years, 9 months ago (2014-03-11 17:12:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19814 (presubmit successful).

Expand Messages | Collapse Messages