Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: chrome/browser/task_management/task_manager_interface.cc

Issue 1912773002: Remove the old task manager view (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/task_management/task_manager_interface.h" 5 #include "chrome/browser/task_management/task_manager_interface.h"
6 6
7 #include "chrome/browser/browser_process.h"
7 #include "chrome/browser/task_management/sampling/task_manager_impl.h" 8 #include "chrome/browser/task_management/sampling/task_manager_impl.h"
8 #include "chrome/browser/task_management/sampling/task_manager_io_thread_helper. h" 9 #include "chrome/browser/task_management/sampling/task_manager_io_thread_helper. h"
9 #include "chrome/browser/task_manager/task_manager.h"
10 #include "chrome/common/chrome_switches.h" 10 #include "chrome/common/chrome_switches.h"
11 #include "chrome/common/pref_names.h"
12 #include "components/prefs/pref_registry_simple.h"
13 #include "components/prefs/pref_service.h"
11 #include "content/public/browser/browser_thread.h" 14 #include "content/public/browser/browser_thread.h"
12 15
16 #if defined(OS_MACOSX)
17 #include "chrome/browser/ui/browser_dialogs.h"
18 #endif // defined(OS_MACOSX)
19
13 namespace task_management { 20 namespace task_management {
14 21
15 // static 22 // static
23 void TaskManagerInterface::RegisterPrefs(PrefRegistrySimple* registry) {
24 registry->RegisterDictionaryPref(prefs::kTaskManagerWindowPlacement);
25 registry->RegisterDictionaryPref(prefs::kTaskManagerColumnVisibility);
26 registry->RegisterBooleanPref(prefs::kTaskManagerEndProcessEnabled, true);
27 }
28
29 // static
30 bool TaskManagerInterface::IsEndProcessEnabled() {
31 PrefService* state = g_browser_process->local_state();
32 return !state || state->GetBoolean(prefs::kTaskManagerEndProcessEnabled);
33 }
34
35 #if defined(OS_MACOSX)
36 // static
37 bool TaskManagerInterface::IsNewTaskManagerEnabled() {
38 return chrome::ToolkitViewsDialogsEnabled();
39 }
40 #endif // defined(OS_MACOSX)
41
42 // static
16 TaskManagerInterface* TaskManagerInterface::GetTaskManager() { 43 TaskManagerInterface* TaskManagerInterface::GetTaskManager() {
17 DCHECK_CURRENTLY_ON(content::BrowserThread::UI); 44 DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
18 45
19 return TaskManagerImpl::GetInstance(); 46 return TaskManagerImpl::GetInstance();
20 } 47 }
21 48
22 // static 49 // static
23 void TaskManagerInterface::OnRawBytesRead(const net::URLRequest& request, 50 void TaskManagerInterface::OnRawBytesRead(const net::URLRequest& request,
24 int64_t bytes_read) { 51 int64_t bytes_read) {
25 DCHECK_CURRENTLY_ON(content::BrowserThread::IO); 52 DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
26 53
27 if (switches::NewTaskManagerEnabled()) 54 #if defined(OS_MACOSX)
28 TaskManagerIoThreadHelper::OnRawBytesRead(request, bytes_read); 55 if (chrome::NotifyOldTaskManagerBytesRead(request, bytes_read))
29 else 56 return;
30 TaskManager::GetInstance()->model()->NotifyBytesRead(request, bytes_read); 57 #endif // defined(OS_MACOSX)
58
59 TaskManagerIoThreadHelper::OnRawBytesRead(request, bytes_read);
31 } 60 }
32 61
33 void TaskManagerInterface::AddObserver(TaskManagerObserver* observer) { 62 void TaskManagerInterface::AddObserver(TaskManagerObserver* observer) {
34 observers_.AddObserver(observer); 63 observers_.AddObserver(observer);
35 observer->observed_task_manager_ = this; 64 observer->observed_task_manager_ = this;
36 65
37 ResourceFlagsAdded(observer->desired_resources_flags()); 66 ResourceFlagsAdded(observer->desired_resources_flags());
38 67
39 base::TimeDelta current_refresh_time = GetCurrentRefreshTime(); 68 base::TimeDelta current_refresh_time = GetCurrentRefreshTime();
40 if (current_refresh_time == base::TimeDelta::Max()) { 69 if (current_refresh_time == base::TimeDelta::Max()) {
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 } 168 }
140 169
141 void TaskManagerInterface::ScheduleRefresh(base::TimeDelta refresh_time) { 170 void TaskManagerInterface::ScheduleRefresh(base::TimeDelta refresh_time) {
142 refresh_timer_->Start(FROM_HERE, 171 refresh_timer_->Start(FROM_HERE,
143 refresh_time, 172 refresh_time,
144 base::Bind(&TaskManagerInterface::Refresh, 173 base::Bind(&TaskManagerInterface::Refresh,
145 base::Unretained(this))); 174 base::Unretained(this)));
146 } 175 }
147 176
148 } // namespace task_management 177 } // namespace task_management
OLDNEW
« no previous file with comments | « chrome/browser/task_management/task_manager_interface.h ('k') | chrome/browser/task_management/task_manager_tester.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698