Remove the old task manager view

chrome/browser/task_management/task_manager_tester.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/task_management/task_manager_tester.h"
 
 #include "base/memory/ptr_util.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sessions/session_tab_helper.h"
 #include "chrome/browser/task_management/task_manager_interface.h"
-#include "chrome/browser/task_manager/legacy_task_manager_tester.h"
 #include "chrome/browser/ui/browser_dialogs.h"
 #include "chrome/browser/ui/task_manager/task_manager_table_model.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/grit/generated_resources.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/models/table_model_observer.h"
 
+#if defined(OS_MACOSX)
+#include "chrome/browser/task_manager/legacy_task_manager_tester.h"
+#endif  // defined(OS_MACOSX)
+
 namespace task_management {
 
 namespace {
 
 // Returns whether chrome::ShowTaskManager() will, for the current platform and
 // command line, show a view backed by a task_management::TaskManagerTableModel.
 bool IsNewTaskManagerViewEnabled() {

[ncarter (slow), 2016/05/19 22:25:07]

I would just inline this function. It's only called in two spots, one of which
is already #ifdef'd, and the other of which is a CHECK that may not even be
necessary.

[afakhry, 2016/05/20 02:32:50]

Done.

 #if defined(OS_MACOSX)
-  if (!chrome::ToolkitViewsDialogsEnabled())
-    return false;
+  return TaskManagerInterface::IsNewTaskManagerEnabled();
 #endif
-  return switches::NewTaskManagerEnabled();
+  return true;
 }
 
 // Temporarily intercepts the calls between a TableModel and its Observer,
 // running |callback| whenever anything happens.
 class ScopedInterceptTableModelObserver : public ui::TableModelObserver {
  public:
   ScopedInterceptTableModelObserver(
       ui::TableModel* model_to_intercept,
       ui::TableModelObserver* real_table_model_observer,
       const base::Closure& callback)
@@ skipping 122 matching lines @@
     return result;
   }
 
   task_management::TaskManagerTableModel* model_;
   std::unique_ptr<ScopedInterceptTableModelObserver> interceptor_;
 };
 
 // static
 std::unique_ptr<TaskManagerTester> TaskManagerTester::Create(
     const base::Closure& callback) {
-  if (IsNewTaskManagerViewEnabled())
-    return base::WrapUnique(new TaskManagerTesterImpl(callback));
-  else
+#if defined(OS_MACOSX)
+  if (!IsNewTaskManagerViewEnabled())
     return task_manager::CreateLegacyTaskManagerTester(callback);
+#endif  // defined(OS_MACOSX)
+
+  return base::WrapUnique(new TaskManagerTesterImpl(callback));
 }
 
 }  // namespace task_management