Remove the old task manager view

chrome/chrome_tests_unit.gypi

 # Copyright 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 {
   'variables': {
     'chrome_unit_tests_sources': [
       # histograms.xml is analyzed by AboutFlagsHistogramTest, so this
       # dependency is needed to make commit bots run unit_tests on
       # histograms.xml changes.
       '../tools/metrics/histograms/histograms.xml',
@@ skipping 702 matching lines @@
       'browser/ui/ash/launcher/test/test_chrome_launcher_app_menu_item.cc',
       'browser/ui/ash/launcher/test/test_chrome_launcher_app_menu_item.h',
     ],
     'chrome_unit_tests_task_manager_sources': [
       # New Task Manager Tests Sources:
       'browser/task_management/providers/browser_process_task_unittest.cc',
       'browser/task_management/providers/child_process_task_unittest.cc',
       'browser/task_management/task_manager_observer_unittest.cc',
       'browser/task_management/test_task_manager.cc',
       'browser/task_management/test_task_manager.h',
-      # Old Task Manager Tests Sources:
+    ],
+    'chrome_unit_tests_old_task_manager_mac_sources': [
+      # Old Task Manager Tests Sources (enabled only on mac):
       'browser/task_manager/task_manager_unittest.cc',

[tapted, 2016/04/26 01:54:04]

Move these to chrome_unit_tests_cocoa_sources (with the comment) - we don't need
the extra variable

[afakhry, 2016/04/26 22:22:44]

Done.

       'browser/task_manager/task_manager_util_unittest.cc',
     ],
     'chrome_unit_tests_mdns_sources': [
       'browser/local_discovery/local_domain_resolver_unittest.cc',
       'browser/local_discovery/service_discovery_client_unittest.cc',
       'browser/printing/cloud_print/privet_device_lister_unittest.cc',
       'browser/printing/cloud_print/privet_local_printer_lister_unittest.cc',
     ],
     'chrome_unit_tests_service_discovery_sources': [
       'browser/devtools/device/cast_device_provider_unittest.cc',
@@ skipping 1697 matching lines @@
           'dependencies': [
             'browser/ui/libgtk2ui/libgtk2ui.gyp:gtk2ui',
             '../build/linux/system.gyp:gio',
           ],
         }],
         ['use_aura==1 or toolkit_views==1', {
           'dependencies': [
             '../ui/events/events.gyp:events_test_support',
           ],
         }],
         ['enable_task_manager==1', {

[tapted, 2016/04/26 01:54:04]

It's weird to have this for test targets but not the main browser in
chrome_browser.gypi [we should probably remove enable_task_manager and just use
!android, but that's orthogonal). I guess this CL doesn't make things
significantly worse.

           'sources': [ '<@(chrome_unit_tests_task_manager_sources)' ],
           'dependencies': [ '../gpu/gpu.gyp:gpu' ],
+          'conditions': [
+            ['OS == "mac"', {
+              'sources': [
+                '<@(chrome_unit_tests_old_task_manager_mac_sources)'
+              ],
+            }],
+          ],
         }],
         ['enable_mdns==1', {
           'sources': [ '<@(chrome_unit_tests_mdns_sources)' ],
         }],
         ['enable_service_discovery==1', {
           'sources': [ '<@(chrome_unit_tests_service_discovery_sources)' ],
         }],
         ['enable_web_speech==1', {
           'sources': [ '<@(chrome_unit_tests_speech_sources)' ],
         }],
@@ skipping 558 matching lines @@
               'dependencies': [
                 '../tools/xdisplaycheck/xdisplaycheck.gyp:xdisplaycheck',
               ],
             }],
           ],
         },
       ],
     }],
   ],  # 'conditions'
 }