Remove the old task manager view

chrome/browser/task_management/task_manager_interface.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/task_management/task_manager_interface.h"
 
+#include "chrome/browser/browser_process.h"
 #include "chrome/browser/task_management/sampling/task_manager_impl.h"
 #include "chrome/browser/task_management/sampling/task_manager_io_thread_helper.h"
-#include "chrome/browser/task_manager/task_manager.h"
 #include "chrome/common/chrome_switches.h"
+#include "chrome/common/pref_names.h"
+#include "components/prefs/pref_registry_simple.h"
+#include "components/prefs/pref_service.h"
 #include "content/public/browser/browser_thread.h"
 
+#if defined(OS_MACOSX)
+#include "chrome/browser/task_manager/task_manager.h"
+#endif  // defined(OS_MACOSX)
+
 namespace task_management {
 
 // static
+void TaskManagerInterface::RegisterPrefs(PrefRegistrySimple* registry) {
+  registry->RegisterDictionaryPref(prefs::kTaskManagerWindowPlacement);
+  registry->RegisterDictionaryPref(prefs::kTaskManagerColumnVisibility);
+  registry->RegisterBooleanPref(prefs::kTaskManagerEndProcessEnabled, true);
+}
+
+// static
+bool TaskManagerInterface::IsEndProcessEnabled() {
+  auto* state = g_browser_process->local_state();

[tapted, 2016/04/26 01:54:03]

nit: auto* -> PrefService*  (I don't think this meets the "code is more readable
with auto" requirement)

[afakhry, 2016/04/26 22:22:43]

Done.

+  return state ? state->GetBoolean(prefs::kTaskManagerEndProcessEnabled) : true;

[tapted, 2016/04/26 01:54:03]

optional-nit: I'd write this `return !state || state->GetBoolean(..)`

[afakhry, 2016/04/26 22:22:43]

I like it. Done!

+}
+
+// static
 TaskManagerInterface* TaskManagerInterface::GetTaskManager() {
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
 
   return TaskManagerImpl::GetInstance();
 }
 
 // static
 void TaskManagerInterface::OnRawBytesRead(const net::URLRequest& request,
                                           int64_t bytes_read) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
 
-  if (switches::NewTaskManagerEnabled())
-    TaskManagerIoThreadHelper::OnRawBytesRead(request, bytes_read);
-  else
-    TaskManager::GetInstance()->model()->NotifyBytesRead(request, bytes_read);
+#if defined(OS_MACOSX)
+  TaskManager::GetInstance()->model()->NotifyBytesRead(request, bytes_read);

[tapted, 2016/04/26 01:54:03]

You can already show the new task manager on Mac -- it's currently behind
chrome::ToolkitViewsDialogsEnabled() -- see r386897 and task_manager_mac.mm

I think this should still call a `NewTaskManagerEnabled()` method between the
#if MAC bits, but you can move it out of the switches:: namespace to somewhere
mac-specific -- probably c/b/task_manager/task_manager.h, since you can't
#include c/b/ui/cocoa from here.

Then task_manager_mac.mm should call it as well (and it should just wrap
chrome::ToolkitViewsDialogsEnabled() - but there shouldn't be multiple
task-manager code locations calling chrome::ToolkitViewsDialogsEnabled())

[afakhry, 2016/04/26 22:22:43]

Thanks! Done.

+#else
+  TaskManagerIoThreadHelper::OnRawBytesRead(request, bytes_read);
+#endif  // defined(OS_MACOSX)
 }
 
 void TaskManagerInterface::AddObserver(TaskManagerObserver* observer) {
   observers_.AddObserver(observer);
   observer->observed_task_manager_ = this;
 
   ResourceFlagsAdded(observer->desired_resources_flags());
 
   base::TimeDelta current_refresh_time = GetCurrentRefreshTime();
   if (current_refresh_time == base::TimeDelta::Max()) {
@@ skipping 98 matching lines @@
 }
 
 void TaskManagerInterface::ScheduleRefresh(base::TimeDelta refresh_time) {
   refresh_timer_->Start(FROM_HERE,
                         refresh_time,
                         base::Bind(&TaskManagerInterface::Refresh,
                                    base::Unretained(this)));
 }
 
 }  // namespace task_management