Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1912763002:
Roll PDFium e3bbfa2..0f6425f (Closed)
|
Created:
4 years, 8 months ago by Oliver Chang Modified:
4 years, 7 months ago Reviewers:
dsinclair CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll PDFium e3bbfa2..0f6425f
https://pdfium.googlesource.com/pdfium.git/+log/e3bbfa2..0f6425f
BUG=605491, 590711
TBR=dsinclair@chromium.org
TEST=bots
Committed: https://crrev.com/58b579ece9fcbc9d38ea9c186b4898685067d3ae
Cr-Commit-Position: refs/heads/master@{#388898}
Patch Set 1 #Messages
Total messages: 15 (8 generated)
Description was changed from ========== Roll PDFium e3bbfa2..0f6425f https://pdfium.googlesource.com/pdfium.git/+log/e3bbfa2..0f6425f BUG=605491,590711 TEST=bots ========== to ========== Roll PDFium e3bbfa2..0f6425f https://pdfium.googlesource.com/pdfium.git/+log/e3bbfa2..0f6425f BUG=605491,590711 TEST=bots ==========
ochang@chromium.org changed reviewers: + dsinclair@chromium.org
TBR
The CQ bit was checked by ochang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912763002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== Roll PDFium e3bbfa2..0f6425f https://pdfium.googlesource.com/pdfium.git/+log/e3bbfa2..0f6425f BUG=605491,590711 TEST=bots ========== to ========== Roll PDFium e3bbfa2..0f6425f https://pdfium.googlesource.com/pdfium.git/+log/e3bbfa2..0f6425f BUG=605491,590711 TBR=dsinclair@chromium.org TEST=bots ==========
The CQ bit was checked by ochang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912763002/1
lgtm
Message was sent while issue was closed.
Description was changed from ========== Roll PDFium e3bbfa2..0f6425f https://pdfium.googlesource.com/pdfium.git/+log/e3bbfa2..0f6425f BUG=605491,590711 TBR=dsinclair@chromium.org TEST=bots ========== to ========== Roll PDFium e3bbfa2..0f6425f https://pdfium.googlesource.com/pdfium.git/+log/e3bbfa2..0f6425f BUG=605491,590711 TBR=dsinclair@chromium.org TEST=bots ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Roll PDFium e3bbfa2..0f6425f https://pdfium.googlesource.com/pdfium.git/+log/e3bbfa2..0f6425f BUG=605491,590711 TBR=dsinclair@chromium.org TEST=bots ========== to ========== Roll PDFium e3bbfa2..0f6425f https://pdfium.googlesource.com/pdfium.git/+log/e3bbfa2..0f6425f BUG=605491,590711 TBR=dsinclair@chromium.org TEST=bots Committed: https://crrev.com/58b579ece9fcbc9d38ea9c186b4898685067d3ae Cr-Commit-Position: refs/heads/master@{#388898} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/58b579ece9fcbc9d38ea9c186b4898685067d3ae Cr-Commit-Position: refs/heads/master@{#388898} |
