Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1912743002: [turbofan] Properly wire ObjectIs<Type> diamonds. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@SimplifiedLowering
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly wire ObjectIs<Type> diamonds. The ObjectIs<Type> predicates compile down to diamonds (in the general case), and those should be connected properly to the control and effect chain in the linearization pass. R=jarin@chromium.org Committed: https://crrev.com/256eeed5c3e5a9b3e881f72c1ebceae1b51ccdcc Cr-Commit-Position: refs/heads/master@{#35748}

Patch Set 1 #

Patch Set 2 : Fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -0 lines) Patch
M src/compiler/effect-control-linearizer.h View 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 1 2 chunks +199 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 8 months ago (2016-04-21 19:19:03 UTC) #1
Benedikt Meurer
Hey Jaro, Linearize all the control flow, so we can optimize it! :-) Please take ...
4 years, 8 months ago (2016-04-21 19:19:55 UTC) #2
Jarin
lgtm
4 years, 8 months ago (2016-04-25 05:55:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912743002/20001
4 years, 8 months ago (2016-04-25 05:56:24 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-25 06:12:44 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 06:14:45 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/256eeed5c3e5a9b3e881f72c1ebceae1b51ccdcc
Cr-Commit-Position: refs/heads/master@{#35748}

Powered by Google App Engine
This is Rietveld 408576698