Issue 191273002: Revert "Remove the HTMLVideoElement-specific prefixed fullscreen API"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 191273002: Revert "Remove the HTMLVideoElement-specific prefixed fullscreen API" (Closed)

Created:
6 years, 9 months ago by philipj_slow

Modified:
6 years, 9 months ago

Reviewers:
acolwell GONE FROM CHROMIUM

CC:
blink-reviews, nessy, arv+blink, gasubic, fs, eric.carlson_apple.com, watchdog-blink-watchlist_google.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert "Remove the HTMLVideoElement-specific prefixed fullscreen API" Revert "Reduce HTMLMediaElement BehaviorRestrictions to a single state bit" This reverts r167815 and r167864. The removal broke YouTube on Android, so revert for now: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Bxe7DnDVRZ0/QI4zkfKVfQsJ BUG=346236

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+166 lines, -28 lines)			Patch
M	LayoutTests/fullscreen/full-screen-iframe-legacy.html	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	LayoutTests/fullscreen/full-screen-iframe-legacy-expected.txt	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	LayoutTests/media/video-controls-visible-exiting-fullscreen.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/media/video-controls-visible-exiting-fullscreen-expected.txt	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	LayoutTests/media/video-enter-fullscreen-without-user-gesture.html	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/media/video-enter-fullscreen-without-user-gesture-expected.txt	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	LayoutTests/media/video-play-require-user-gesture.html	View	4 chunks	+11 lines, -2 lines	0 comments	Download
M	LayoutTests/media/video-play-require-user-gesture-expected.txt	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	Source/core/frame/UseCounter.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/core/frame/UseCounter.cpp	View	1 chunk	+18 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLMediaElement.h	View	5 chunks	+19 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLMediaElement.cpp	View	9 chunks	+25 lines, -8 lines	0 comments	Download
M	Source/core/html/HTMLVideoElement.h	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLVideoElement.cpp	View	2 chunks	+46 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLVideoElement.idl	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

philipj_slow

6 years, 9 months ago (2014-03-11 16:20:23 UTC) #2

Closing as Jochen wrote "I think it's prudent to hold back the revert for now
until we've fully understood the situation" on blink-dev. Will re-open if/when
needed.

Expand Messages | Collapse Messages