headless: Add support for host resolver mapping

headless: Add support for host resolver mapping

BUG=598644
Committed: https://crrev.com/d264bd58220beb3b81b61a798d09482d7b19a0cd
Cr-Commit-Position: refs/heads/master@{#389093}

[Sami, 2016-04-21 14:12:42]

Description was changed from

==========
headless: Add support for host resolver mapping

BUG=598644
==========

to

==========
headless: Add support for host resolver mapping

BUG=598644
==========

[Sami, 2016-04-21 14:12:42]

skyostil@chromium.org changed reviewers:
+ altimin@chromium.org

[altimin, 2016-04-21 14:35:55]

lgtm with one nit

https://codereview.chromium.org/1912673002/diff/1/headless/lib/headless_brows...
File headless/lib/headless_browser_browsertest.cc (right):

https://codereview.chromium.org/1912673002/diff/1/headless/lib/headless_brows...
headless/lib/headless_browser_browsertest.cc:70:
IN_PROC_BROWSER_TEST_F(HeadlessBrowserTest, SetProxyServer) {
Nit: maybe we can come up with a better name for this test?
SetHostResolverRules?

[Sami, 2016-04-21 14:58:37]

Thanks for the review.

https://codereview.chromium.org/1912673002/diff/1/headless/lib/headless_brows...
File headless/lib/headless_browser_browsertest.cc (right):

https://codereview.chromium.org/1912673002/diff/1/headless/lib/headless_brows...
headless/lib/headless_browser_browsertest.cc:70:
IN_PROC_BROWSER_TEST_F(HeadlessBrowserTest, SetProxyServer) {
On 2016/04/21 14:35:55, altimin wrote:
> Nit: maybe we can come up with a better name for this test?
> SetHostResolverRules?

Hmm, not a bad idea :D

[Sami, 2016-04-22 13:25:04]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2016-04-22 13:25:04]

The patchset sent to the CQ was uploaded after l-g-t-m from altimin@chromium.org
Link to the patchset: https://codereview.chromium.org/1912673002/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2016-04-22 13:25:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1912673002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1912673002/40001

[Sami, 2016-04-22 13:25:51]

The CQ bit was unchecked by skyostil@chromium.org

[Sami, 2016-04-22 13:29:26]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2016-04-22 13:29:26]

The patchset sent to the CQ was uploaded after l-g-t-m from altimin@chromium.org
Link to the patchset: https://codereview.chromium.org/1912673002/#ps60001
(title: "Rebased again")

[commit-bot: I haz the power, 2016-04-22 13:29:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1912673002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1912673002/60001

[commit-bot: I haz the power, 2016-04-22 14:00:36]

Description was changed from

==========
headless: Add support for host resolver mapping

BUG=598644
==========

to

==========
headless: Add support for host resolver mapping

BUG=598644
==========

[commit-bot: I haz the power, 2016-04-22 14:00:37]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-22 19:46:54]

Description was changed from

==========
headless: Add support for host resolver mapping

BUG=598644
==========

to

==========
headless: Add support for host resolver mapping

BUG=598644

Committed: https://crrev.com/d264bd58220beb3b81b61a798d09482d7b19a0cd
Cr-Commit-Position: refs/heads/master@{#389093}
==========

[commit-bot: I haz the power, 2016-04-22 19:46:55]

Patchset 4 (id:??) landed as
https://crrev.com/d264bd58220beb3b81b61a798d09482d7b19a0cd
Cr-Commit-Position: refs/heads/master@{#389093}