Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Unified Diff: src/objects.h

Issue 1912633002: [ic] Split LoadIC into LoadGlobalIC and LoadIC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebasing Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/log.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index bb00506640d83644c2b608287d3522ce641d421a..9f4a82462fb3e6e6eb816e460d59a472787f6560 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -4873,6 +4873,7 @@ class Code: public HeapObject {
#define IC_KIND_LIST(V) \
V(LOAD_IC) \
+ V(LOAD_GLOBAL_IC) \
V(KEYED_LOAD_IC) \
V(CALL_IC) \
V(STORE_IC) \
@@ -4892,10 +4893,6 @@ class Code: public HeapObject {
NUMBER_OF_KINDS
};
- // No more than 32 kinds. The value is currently encoded in five bits in
- // Flags.
- STATIC_ASSERT(NUMBER_OF_KINDS <= 32);
-
static const char* Kind2String(Kind kind);
static const int kPrologueOffsetNotSet = -1;
@@ -5282,6 +5279,7 @@ class Code: public HeapObject {
// Flags layout. BitField<type, shift, size>.
class CacheHolderField : public BitField<CacheHolderFlag, 0, 2> {};
class KindField : public BitField<Kind, CacheHolderField::kNext, 5> {};
+ STATIC_ASSERT(NUMBER_OF_KINDS <= KindField::kMax);
class ExtraICStateField : public BitField<ExtraICState, KindField::kNext,
PlatformSmiTagging::kSmiValueSize -
KindField::kNext + 1> {};
« no previous file with comments | « src/log.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698