Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1912613002: Revert "Reland: Tie kWebRtcH264WithOpenH264FFmpeg and kEnableWebRtcHWH264Encoding flags on Mac" (Closed)

Created:
4 years, 8 months ago by kjellander_chromium
Modified:
4 years, 8 months ago
Reviewers:
mcasas, hbos_chromium
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, torbjorng
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Reland: Tie kWebRtcH264WithOpenH264FFmpeg and kEnableWebRtcHWH264Encoding flags on Mac" This reverts commit 3e6e8e36cbd14975a4ff345dd153b24db6e4c444. Reason: Causes timeouts and lots of ERROR:video_sender.cc(313)] Failed to encode frame. Error code: -1 errors on WebRTC Mac bots for the h264 tests. See https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/53766 BUG=597334 TBR=mcasas@chromium.org, hbos@chromium.org Committed: https://crrev.com/bae3d9c4e63d37ebaaffc6a7c381b40d2d064105 Cr-Commit-Position: refs/heads/master@{#388759}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/vt_video_encode_accelerator_mac.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M content/renderer/media/rtc_video_encoder_factory.cc View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912613002/1
4 years, 8 months ago (2016-04-21 12:26:43 UTC) #2
kjellander_chromium
4 years, 8 months ago (2016-04-21 12:26:45 UTC) #3
kjellander_chromium
+torbjorng
4 years, 8 months ago (2016-04-21 12:28:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 13:46:57 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:34:14 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bae3d9c4e63d37ebaaffc6a7c381b40d2d064105
Cr-Commit-Position: refs/heads/master@{#388759}

Powered by Google App Engine
This is Rietveld 408576698