Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1912593003: gDefaultProfileIsSRGB symbol must exist in .so (Closed)

Created:
4 years, 8 months ago by hal.canary
Modified:
4 years, 8 months ago
Reviewers:
herb_g, jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

gDefaultProfileIsSRGB symbol must exist in .so fix fiddle TBR= Committed: https://skia.googlesource.com/skia/+/730058f6a89c0d949d2be539be08a935e78c6d8e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/core/SkImageInfo.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
hal.canary
ptal
4 years, 8 months ago (2016-04-21 16:41:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912593003/1
4 years, 8 months ago (2016-04-21 16:42:32 UTC) #7
mtklein
The better fix here might be to remove uses of this value from SkImageInfo.h so ...
4 years, 8 months ago (2016-04-21 16:49:44 UTC) #9
mtklein
On 2016/04/21 at 16:49:44, mtklein wrote: > The better fix here might be to remove ...
4 years, 8 months ago (2016-04-21 16:51:21 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-21 16:56:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/730058f6a89c0d949d2be539be08a935e78c6d8e

Powered by Google App Engine
This is Rietveld 408576698