Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1912523002: Makes ScreenMus not check that displays are non-empty (Closed)

Created:
4 years, 8 months ago by sky
Modified:
4 years, 8 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes ScreenMus not check that displays are non-empty WaitForIncomingMethodCall can return in the case of the pipe being broken (say mus is going down). Adds code to handle that case. BUG=594600 TEST=none R=ben@chromium.org Committed: https://crrev.com/02bf716e8ebff39a2a8c0230bfa621bdbec24683 Cr-Commit-Position: refs/heads/master@{#388696}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M ui/views/mus/screen_mus.cc View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sky
4 years, 8 months ago (2016-04-21 04:05:12 UTC) #1
Ben Goodger (Google)
lgtm
4 years, 8 months ago (2016-04-21 04:08:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1912523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1912523002/1
4 years, 8 months ago (2016-04-21 04:25:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 04:56:25 UTC) #5
kjellander_chromium
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1905893002/ by kjellander@chromium.org. ...
4 years, 8 months ago (2016-04-21 07:50:00 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:31:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02bf716e8ebff39a2a8c0230bfa621bdbec24683
Cr-Commit-Position: refs/heads/master@{#388696}

Powered by Google App Engine
This is Rietveld 408576698