Issue 1912503003: Instead of using ProfileCompare in InputImeEventRouterFactory::router_map_ when trying to remove pr…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1912503003: Instead of using ProfileCompare in InputImeEventRouterFactory::router_map_ when trying to remove pr… (Closed)

Created:
4 years, 8 months ago by Shu Chen

Modified:
4 years, 8 months ago

Reviewers:

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

Instead of using ProfileCompare in InputImeEventRouterFactory::router_map_ when trying to remove profile, just compares the profile directly. BUG=602746 TEST=Verfied not repo on local build. Review URL: https://codereview.chromium.org/1896993003 Cr-Commit-Position: refs/heads/master@{#388431} (cherry picked from commit 13814091e327ebc1792dfb329b88d2289568a78a) Committed: https://chromium.googlesource.com/chromium/src/+/5387cfbe0137772ae3b263144e4cd8f735baf9f1

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/extensions/api/input_ime/input_ime_api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

Shu Chen

4 years, 8 months ago (2016-04-21 05:08:13 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5387cfbe0137772ae3b263144e4cd8f735baf9f1.